Coder Social home page Coder Social logo

Comments (2)

hughsando avatar hughsando commented on September 18, 2024

Yes, that code is wrong. the std::string will deallocate when it leaves scope and mess-up the return pointer (same goes for the empty pointer). You could either return the std::string by value, and then take the c_str in the calling function, or do something like this (assuming you are attached to the GC)

HxString JStringToHxString(JNIEnv *env, jstring inString, bool inReleaseLocalRef)
{
   const char *c_ptr = env->GetStringUTFChars(inString, 0);
   HxString result(c_ptr);
   env->ReleaseStringUTFChars(inString, c_ptr);
   if (inReleaseLocalRef)
      env->DeleteLocalRef(inString);
   return result;
}

It is also safe to take the c_str in this case because the hxcpp GC should be able to identify it on the stack.
But if you just want a "const char *" for c++ code, you could use:

    ...
        if (mid == 0)
            return "";

        jstring jPref = (jstring) env->CallStaticObjectMethod(cls, mid);
       const char *c_ptr = env->GetStringUTFChars(jPref, 0);
       int len = strlen(c_ptr);
       const char *result = alloc_string_data(c_ptr, len);
       env->ReleaseStringUTFChars(jPref, c_ptr);

       return result;

which avoid possible translations between wide-char encoding

from nme.

codeservice avatar codeservice commented on September 18, 2024

I tested keep using "const char*" option. It works great and require minimal code changes. To save time I will propose this change to github ...

from nme.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.