Comments (2)
Yes, that code is wrong. the std::string will deallocate when it leaves scope and mess-up the return pointer (same goes for the empty pointer). You could either return the std::string by value, and then take the c_str in the calling function, or do something like this (assuming you are attached to the GC)
HxString JStringToHxString(JNIEnv *env, jstring inString, bool inReleaseLocalRef)
{
const char *c_ptr = env->GetStringUTFChars(inString, 0);
HxString result(c_ptr);
env->ReleaseStringUTFChars(inString, c_ptr);
if (inReleaseLocalRef)
env->DeleteLocalRef(inString);
return result;
}
It is also safe to take the c_str in this case because the hxcpp GC should be able to identify it on the stack.
But if you just want a "const char *" for c++ code, you could use:
...
if (mid == 0)
return "";
jstring jPref = (jstring) env->CallStaticObjectMethod(cls, mid);
const char *c_ptr = env->GetStringUTFChars(jPref, 0);
int len = strlen(c_ptr);
const char *result = alloc_string_data(c_ptr, len);
env->ReleaseStringUTFChars(jPref, c_ptr);
return result;
which avoid possible translations between wide-char encoding
from nme.
I tested keep using "const char*" option. It works great and require minimal code changes. To save time I will propose this change to github ...
from nme.
Related Issues (20)
- JNI callbacks via HaxeObject crash HOT 5
- Building android fails on linux because of change the FileSystem.fullPath behaviour in haxe 4.1.4
- Crash caused by preemptive mode HOT 2
- fix continues integration HOT 3
- make tooling lix compatible HOT 2
- [QUESTION] Flash Player Emulator HOT 3
- relatively rare timer crash. can't get why yet HOT 7
- [QUESTION] How accurate cubicTo method? HOT 2
- Window close events
- Incompatibility with SWF library HOT 4
- Unable to run sample project on Linux HOT 3
- nme setup fails on M1 Mac
- CapabilitiesGetScreenDPI on Mac retina display concern HOT 8
- Video player on android 11 issue HOT 1
- nme build is adding empty `-cp`s
- Build Error: Invalid character: / HOT 3
- nme build neko create an empty output file.
- xcode 14.0.1 NME app hang risk warning
- Cant compile NME for android with latest hxcpp changes
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nme.