Feature Request :: AMD Support with RequireJS about ant-build-script

[paulirish]

It'd be cool but mostly we'd require your help in adding the feature. :)

[alvincrespo]

Sounds good to me. I've already forked it and modifying the build.xml to account for requirejs/amd. Can this ticket be assigned to me?

[paulirish]

can't assign it to you but you certainly own it. (in our hearts)

[roblarsen]

How do you picture this working, from an end user perspective?

Also, in lieu of assigning it to you, I can walk downstairs every couple of hours to see how it's going...

[alvincrespo]

@roblarsen I was thinking of basically including the option to set a property, named script.amd, within project.properties to something like amd or amd.jquery with the default being empty for the default behavior that we currently see.

This is what I was thinking of doing, its a bit messy but I'll clean it up eventually before submitting a request:

<echo message="Update the HTML to reference our concatenated script file: ${scripts.js}"/>
<!-- Determines which Regex to use for AMD use -->
<if>
    <equals arg1="${script.type}" arg2="amd"/>
    <then>
        <echo message="Updating HTML to reflect the use of RequireJS"/>
        <property name="matchRegex" value="&lt;!-- scripts concatenated [\d\w\s\W]*&lt;script.*data-main=['&quot;]?(.*)/${file.root.script}(?:\?.*)?['&quot;]?\s*&gt;\s*&lt;/script&gt;[\d\w\s\W]*&lt;!-- end ((scripts)|(concatenated and minified scripts))\s*--&gt;" />
        <property name="replaceRegex" value="&lt;script data-main='\1/${scripts.sha}.js\' src='js/require.js'&gt;&lt;/script&gt;" />
    </then>
    <elseif>
        <equals arg1="${script.type}" arg2="amd.jquery"/>
        <then>
            <echo message="Updating HTML to reflect the use of RequireJS with jQuery"/>
            <property name="matchRegex" value="&lt;!-- scripts concatenated [\d\w\s\W]*&lt;script.*data-main=['&quot;]?(.*)/${file.root.script}(?:\?.*)?['&quot;]?\s*&gt;\s*&lt;/script&gt;[\d\w\s\W]*&lt;!-- end ((scripts)|(concatenated and minified scripts))\s*--&gt;" />
            <property name="replaceRegex" value="&lt;script data-main='\1/${scripts.sha}.js\' src='js/require-jquery.js'&gt;&lt;/script&gt;" />
        </then>
    </elseif>
    <else>
        <echo message="Updating HTML to reflect the use of default script inclusion"/>
        <property name="matchRegex" value="&lt;!-- scripts concatenated [\d\w\s\W]*&lt;script.*src=['&quot;]?(.*)/${file.root.script}(?:\?.*)?['&quot;]?\s*&gt;\s*&lt;/script&gt;[\d\w\s\W]*&lt;!-- end ((scripts)|(concatenated and minified scripts))\s*--&gt;" />
        <property name="replaceRegex" value="&lt;script src='\1/${scripts.sha}.js\'&gt;&lt;/script&gt;" />
    </else>
</if>
<!-- style.css replacement handled as a replacetoken above -->
<replaceregexp match="${matchRegex}"
  replace="${replaceRegex}" flags="m">
    <fileset dir="${dir.intermediate}" includes="${page-files}"/>
</replaceregexp>
<!--[! use comments like this one to avoid having them get minified -->

And in project.properties:

# Optional property used to determine whether to use require.js implementation of AMD
# Note: Make sure to include require.js here: js/libs/
# Set to amd to output: <script data-main='js/hash.js' src='js/require.js'></script>
# Set to amd.jquery to output: <script data-main='js/hash.js' src='js/require-jquery.js'></script>
#   If using amd.jquery remember to remove the jquery files in js/libs and the markup within index.html
script.type = amd.jquery

[roblarsen]

I think it makes sense to set the path to require as a property. We're not shipping it, so we can't rely on it working. If we require that people set the path to require in the project properties it will force them to acknowledge that the file needs to be there and will allow them to place it anywhere (local file system, CDN) without having to touch the XML.

[alvincrespo]

Good idea! I didn't think about that one. Ill switch it out to use a path instead.

[roblarsen]

Yeah, generally we want to avoid having people touch the XML. Especially for something like a path, which is an easy substitution.

[roblarsen]

making magic.