Image Optimization Broken on Linux/Mac about ant-build-script

[bungle]

To get advpng to work I needed to apply this attribute to its apply-tag:

 force="true"

[roblarsen]

#141 and #147 are relevant.

As you can see, it's been a while since this (At least part of this) was brought to my attention. I've been busy with other things and I don't have a Mac, so I can't test any of this there. Which sucks.

I did write the scary, unreliable, version test on Ubuntu, so it breaking there is a little bit of a surprise (but not much of one, since I referred to as "scary" when I came up with the solution.)

I've been hoping to take a day or two at some point and rewrite this whole thing, since it's a big hunk of frankencode at this point. Obviously that hasn't happened, but this feedback on the ugliness will help get it sorted out.

I'm confused as to the os.family issue. I'll have to go through the history to see what the purpose of that was (I don't remember and don't remember doing it myself. )

[bungle]

I mistakenly closed this issue, so I re-opened it. But the errors and fixes are above. Everything works now. But it was rather nasty to debug this issue. Hopefully this gets fixed on mainline too, so others can benefit.

[roblarsen]

I found the commit which introduced the os.family bug.

653451a#L0L897

[bungle]

Yes, that scary test is fine, but Ubuntu 12.04.2 doesn't have 0.7 by default, so it didn't pass the test. I had to install more current version from ppa, which sadly has a bug too, and displays the version as "Hg", which sucks. In general I think it's more problematic to have that test than fail on 0.6.x version (does it even fail with 0.6.x?).

[roblarsen]

Ah, thanks for the clarification. As I said, I want to just rework the whole section. There's just a lot going on so it's going to take a while. We added a lot in the push to get 1.0 out the door (the commit above solved one longstanding issue, in addition to introducing this bug) so it ended up being pretty messy.

[bungle]

Yes, I looked also the history, and that was one scary blob of an update (I did not have these problems on version before that). But with the findings, and workarounds I did, I don't think it's very big problem to fix. Let me know when you have a new version committed so I can confirm that everything works. Thanks for a great tool!

[roblarsen]

Cool. I'll see if I can pull this together tonight or tomorrow. This has bugged me for a while and all this research will make it go a lot quicker than I expected. I'll close this issue once the new version is in.

[roblarsen]

Open for testing
https://github.com/h5bp/ant-build-script/tree/new-image-optimization