greatattractor / imppg Goto Github PK

View Code? Open in Web Editor NEW

82.0 82.0 9.0 16.8 MB

ImPPG (Image Post-Processor)

License: GNU General Public License v3.0

CMake 2.07% C++ 94.21% C 0.82% GLSL 2.52% Shell 0.15% Dockerfile 0.23%

imppg's People

Contributors

Stargazers

Watchers

Forkers

alessiogiambrone mconsidine outdegree dermarcel ftclausen andjones132 nlr-otter jasonwu2010

imppg's Issues

Fails to compile on debian testing

On debian testing the path for fitsio.h is: /usr/include/fitsio.h not cfitsio/fitsio.h

Installation prefix is hardcoded

Hi,

I may be wrong but while checking produced installation file cmake_install.cmake, CMAKE_INSTALL_PREFIX is only checked in the begging and never used in the rest of the file where installation is hard-coded to /usr/local/

cmake_install.cmake

...
# Set the install prefix
if(NOT DEFINED CMAKE_INSTALL_PREFIX)
  set(CMAKE_INSTALL_PREFIX "/usr/local")
endif()
string(REGEX REPLACE "/$" "" CMAKE_INSTALL_PREFIX "${CMAKE_INSTALL_PREFIX}")
...
if("x${CMAKE_INSTALL_COMPONENT}x" STREQUAL "xUnspecifiedx" OR NOT CMAKE_INSTALL_COMPONENT)
  list(APPEND CMAKE_ABSOLUTE_DESTINATION_FILES
   "/usr/local/share/imppg/images/anim.bin;/usr/local/share/imppg/images/crop.png;/usr/local/share/imppg/images/fit_wnd.png;/usr/local/share/imppg/images/imppg-app.ico;/usr/local/share/imppg/images/imppg-app.png;/usr/local/share/imppg/images/load_settings.png;/usr/local/sha
re/imppg/images/mru_settings.png;/usr/local/share/imppg/images/open_file.png;/usr/local/share/imppg/images/pad.png;/usr/local/share/imppg/images/save_file.png;/usr/local/share/imppg/images/save_settings.png;/usr/local/share/imppg/images/select_all.png;/usr/local/share/imppg
/images/toggle_proc.png;/usr/local/share/imppg/images/toggle_tcrv.png;/usr/local/share/imppg/images/zoom_custom.png;/usr/local/share/imppg/images/zoom_in.png;/usr/local/share/imppg/images/zoom_none.png;/usr/local/share/imppg/images/zoom_out.png")
  if(CMAKE_WARN_ON_ABSOLUTE_INSTALL_DESTINATION)
    message(WARNING "ABSOLUTE path INSTALL DESTINATION : ${CMAKE_ABSOLUTE_DESTINATION_FILES}")
  endif()
  if(CMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION)
    message(FATAL_ERROR "ABSOLUTE path INSTALL DESTINATION forbidden (by caller): ${CMAKE_ABSOLUTE_DESTINATION_FILES}")
  endif()
  ...

How may I use a custom prefix installation path?

Accept videos as input for the alignment function

At least SER videos should be supported (aligned output - also as SER). Later also FFMPEG libraries can be used for wider container format support (see libskry for a usage example).

Though the alignment code doesn't care if it's fed a mixture of video frames and/or separate image files, for clarity let's distinguish this in the UI: either a single video file can be specified, or a sequence of image files.

imppg-1.9.0 won't install under Ubuntu-22.04

Hello all,

imppg-1.9.0-Ubuntu_20.04.deb won't install under Ubuntu-22.04 due to it's dependency on libglew2.1. Ubuntu22.04 has libglew2.2 installed and it seems that the previous version is not anymore available. I see 2 options:

A: Is there a workaround (e.g. fake symlinking libglew2.2 to libglew2.1) so that imppg can be installed and used?

B: Will the recently published imppg-1.9.0 will become available for Ubuntu-22.04 (LTS aka long term support) any time soon?

I started loving imppg a while ago and have processed and published many Sun and Moon images (eg. on AstroBin) since, with impressive quality. Currently I am lost, having made the urgent system update from Ubuntu-20.04 to Ubuntu-22.04 because of other dependencies from different programs.

I want imppg back so bad! :) :)

Scripting

ImPPG should be scriptable. This will especially help with trying out slightly different settings for large groups of files. E.g., “process this 500-file sequence with L-R sigma = 1.3, save in output1, then with sigma = 1.4, save in output2, then run FFMPEG on both to create videos for a side-by-side comparison”.

all processing settings shall be exposed through an API, as well as image loading/saving, XML settings file loading/saving, image sequence alignment
recommend to embed a Lua interpreter

Crash when doing Image alignment

I installed the latest version of ImPPG and I am trying to do image alignment on a set if TIFF files but when it does it crashes. I tried in both CPU and GPU modes. I am running latest Windows version and have a fast PC with GTX 3080 card. Are there memory limits or something causing the crash? Each TIFF file is only 1.2mb and I have 82 images. Please let me know if you can help. Thanks!!

Bill

Save image sequence alignement as setting

https://github.com/GreatAttractor/imppg#7-image-sequence-alignment says

The output files are saved under names suffixed with _aligned. FITS files are saved as FITS, the remaining formats: as TIFF files.

This is highly undesirable for long sequences. During yesterday's eclipse I have generated 3300 images and they are in NEF (Nikon's RAW image format). I already need to duplicate them to TIFF since ImPPG does not support NEF, having to duplicate them again to do the alignment is a huge pain. It should be very easy to just store an x-y pairs for each image and be done with that only, no? Bonus points if we can find a format that is compatible with other software, e.g. as if it were a pixelshift image which RawTherapee suppors (but not sure if there is a PP3 corresponding field for it, I can't find the PP3 specifications at the moment)

Cannot load processing settings for Batch processing

I am unable to do batch processing. When I try to load the XML file, nothing changes in the batch processing window. when I try to run bacth processing i get the error "failed to load processing settings" I am using a windows computer. This has always worked for me but suddenly today it is not working.

any suggestions?

Color image processing

Processing of color images shall be supported.

Basic features:

manual and automatic channel alignment (to counter atmospheric dispersion)
joint or per-channel histogram

Additional features/aspects to consider:

per-channel sharpening settings
per-channel tone curve
R&G&B sharpening vs luminance-only sharpening (if L-only, which conversion method to use?)

Up/down buttons accept only one click

Using the 1.9.1.beta version, the up/down buttons for 'Sigma' and 'Amount' only accept one mouseclick and then freeze. The value can change from 1,3000 to 1,2500 or 1,3500 and that's it. No further changes are accepted. The numerical value however can be changed freely by direct input via keyboard.

Unsharp masking info overlay

In the adaptive mode of unsharp masking give the option to highlight the areas that belong to the 1) transition region between min and max amount, 2) dark region using min amount. It can be done e.g. by overlaying a blue (e.g.) checkered (e.g.) pattern over the region(s) in question. Consider that it needs to be reasonably fast also in "CPU & bitmaps" mode.

Planetary mode of image alignment

Add a new image alignment mode for planet rotation animations. After alignment the planet's disc position should be fixed. Phase correlation is not always effective, e.g., when there is a Galilean moon in the FOV.

Cannot align on the Solar Limb

I was able to process my first 85 records then IMPPG crashed. I can no longer process any records with this setting checked. I have 32 logical processors and 128 gigs of ram. It is not my machine. The same thing happens to my friend when he tries to process solar limb files. IMPPG crashes instantly now when I try and run
Tools
Align Image Sequence
Align on Solar Limb

add records
select output folder

Crash

Open RAW images with a plugin?

GIMP cannot open RAW files such as NEF, but with a pluging it can use RawTherapee or DarkTable (and probably other sw too) under the hood.

I know nothing about how GIMP does that, but it would be awesome since it would avoid one having to multiply the number of copies to keep around, which quickly goes out of hands in both filesystem occupation and in "tracking" what-is-what.

Ideally ImPGG should aso be able to use and (optionally) add its editings to the existing sidecar files to prevent further saving of yet other copies as I mentioned in #22 but I guess just being able to open the originals rather than a copy would be a huge boon.

Can't build version 0.6.3

Hi,

I'm about to pack your project for Guix but It failed to build
imppg - tag 0.6.3
build log:

CMake Warning:
  No source or binary directory provided.  Both will be assumed to be the
  same as the current working directory, but note that this warning will
  become a fatal error in future CMake releases.


-- The C compiler identification is GNU 7.5.0
-- The CXX compiler identification is GNU 7.5.0
-- Check for working C compiler: /gnu/store/rn75fm7adgx3pw5j8pg3bczfqq1y17lk-gcc-7.5.0/bin/gcc
-- Check for working C compiler: /gnu/store/rn75fm7adgx3pw5j8pg3bczfqq1y17lk-gcc-7.5.0/bin/gcc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /gnu/store/rn75fm7adgx3pw5j8pg3bczfqq1y17lk-gcc-7.5.0/bin/c++
-- Check for working CXX compiler: /gnu/store/rn75fm7adgx3pw5j8pg3bczfqq1y17lk-gcc-7.5.0/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found PkgConfig: /gnu/store/krpyb0zi700dcrg9cc8932w4v0qivdg9-pkg-config-0.29.2/bin/pkg-config (found version "0.29.2")
-- Found Boost: /gnu/store/vp2s1nxsc9vvc1ix66xpbf041f8nacxr-boost-1.72.0/lib/cmake/Boost-1.72.0/BoostConfig.cmake (found version "1.72.0")
CMake Warning (dev) at /gnu/store/qixwn3dw6glj848hrr3h8fxm6s7wzxm3-cmake-minimal-3.16.5/share/cmake-3.16/Modules/FindwxWidgets.cmake:727 (option):
  Policy CMP0077 is not set: option() honors normal variables.  Run "cmake
  --help-policy CMP0077" for policy details.  Use the cmake_policy command to
  set the policy and suppress this warning.

  For compatibility with older versions of CMake, option is clearing the
  normal variable 'wxWidgets_USE_DEBUG'.
Call Stack (most recent call first):
  /gnu/store/qixwn3dw6glj848hrr3h8fxm6s7wzxm3-cmake-minimal-3.16.5/share/cmake-3.16/Modules/FindwxWidgets.cmake:776 (WX_CONFIG_SELECT_QUERY_BOOL)
  CMakeLists.txt:137 (find_package)
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Found wxWidgets: -L/gnu/store/sg4glq9lbn40bjpbh1kdih08x1iyllzw-wxwidgets-3.0.5.1/lib;-pthread;;;-L/gnu/store/jf269s6clr6r57p8v5c3c1qkyra6apq2-mesa-20.2.4/lib;-lwx_gtk3u_adv-3.0;-lwx_gtk3u_aui-3.0;-lwx_baseu_xml-3.0;-lwx_gtk3u_core-3.0;-lwx_baseu-3.0;-lwx_gtk3u_gl-3.0 (found version "3.0.5")
-- Found OpenMP_C: -fopenmp (found version "4.5")
-- Found OpenMP_CXX: -fopenmp (found version "4.5")
-- Found OpenMP: TRUE (found version "4.5")
-- Performing Test GNU_FFAST_MATH_SUPPORTED
-- Performing Test GNU_FFAST_MATH_SUPPORTED - Success
-- Found GLEW: /gnu/store/0ilpnm42gzg8yg76iyjfziksj4k0gbmi-glew-2.1.0/include (found version "2.1.0")
-- Checking for module 'cfitsio'
--   Found cfitsio, version 3.49
-- Configuring done
-- Generating done
-- Build files have been written to: /tmp/guix-build-imppg-0.6.3.drv-0/source
make[1]: Entering directory '/tmp/guix-build-imppg-0.6.3.drv-0/source'
make[2]: Entering directory '/tmp/guix-build-imppg-0.6.3.drv-0/source'
Scanning dependencies of target imppg
make[2]: Leaving directory '/tmp/guix-build-imppg-0.6.3.drv-0/source'
make[2]: Entering directory '/tmp/guix-build-imppg-0.6.3.drv-0/source'
[  2%] Building CXX object CMakeFiles/imppg.dir/src/about.cpp.o
[  5%] Building CXX object CMakeFiles/imppg.dir/src/adv_settings_wnd.cpp.o
[  7%] Building CXX object CMakeFiles/imppg.dir/src/align_disc.cpp.o
[ 10%] Building CXX object CMakeFiles/imppg.dir/src/align_params.cpp.o
[ 12%] Building CXX object CMakeFiles/imppg.dir/src/align_phasecorr.cpp.o
[ 15%] Building CXX object CMakeFiles/imppg.dir/src/align_proc.cpp.o
[ 17%] Building CXX object CMakeFiles/imppg.dir/src/align_progress.cpp.o
[ 20%] Building CXX object CMakeFiles/imppg.dir/src/appconfig.cpp.o
[ 22%] Building CXX object CMakeFiles/imppg.dir/src/backend/cpu_bmp/cpu_bmp_core.cpp.o
[ 25%] Building CXX object CMakeFiles/imppg.dir/src/backend/cpu_bmp/cpu_bmp_proc.cpp.o
[ 27%] Building CXX object CMakeFiles/imppg.dir/src/backend/cpu_bmp/w_lrdeconv.cpp.o
[ 30%] Building CXX object CMakeFiles/imppg.dir/src/backend/cpu_bmp/w_tcurve.cpp.o
[ 32%] Building CXX object CMakeFiles/imppg.dir/src/backend/cpu_bmp/w_unshmask.cpp.o
[ 35%] Building CXX object CMakeFiles/imppg.dir/src/backend/cpu_bmp/worker.cpp.o
[ 37%] Building CXX object CMakeFiles/imppg.dir/src/batch_params.cpp.o
[ 40%] Building CXX object CMakeFiles/imppg.dir/src/batch.cpp.o
[ 42%] Building CXX object CMakeFiles/imppg.dir/src/common.cpp.o
[ 45%] Building CXX object CMakeFiles/imppg.dir/src/cursors.cpp.o
[ 47%] Building CXX object CMakeFiles/imppg.dir/src/fft.cpp.o
[ 50%] Building CXX object CMakeFiles/imppg.dir/src/formats.cpp.o
[ 52%] Building CXX object CMakeFiles/imppg.dir/src/gauss.cpp.o
[ 55%] Building CXX object CMakeFiles/imppg.dir/src/image.cpp.o
/tmp/guix-build-imppg-0.6.3.drv-0/source/src/image.cpp: In static member function ‘static std::optional<std::unique_ptr<IImageBuffer> > c_FreeImageBuffer::Create(c_FreeImageHandleWrapper&&)’:
/tmp/guix-build-imppg-0.6.3.drv-0/source/src/image.cpp:195:12: error: could not convert ‘result’ from ‘std::unique_ptr<IImageBuffer>’ to ‘std::optional<std::unique_ptr<IImageBuffer> >’
     return result;
            ^~~~~~
make[2]: *** [CMakeFiles/imppg.dir/build.make:336: CMakeFiles/imppg.dir/src/image.cpp.o] Error 1
make[2]: Leaving directory '/tmp/guix-build-imppg-0.6.3.drv-0/source'
make[1]: *** [CMakeFiles/Makefile2:76: CMakeFiles/imppg.dir/all] Error 2
make[1]: Leaving directory '/tmp/guix-build-imppg-0.6.3.drv-0/source'
make: *** [Makefile:152: all] Error 2
command "make" failed with status 2

Aborted empty error when trying to align sun fit images

Hi, I'm trying to align some photos (almost 900 pieces), with fits extension. After start processing, app giving me empty abort error:

macOS build: CXXFLAGS needed (for me) on macOS Monterey 12.5.1 and Xcode 13.4.1

Summary: I needed to set CXXFLAGS="-I/usr/local/include -std=c++17" prior to building on macOS (with Homebrew dependencies) otherwise it failed due to incorrect C++ standard and also boost was not found.

Details:

I amended the steps as follows and successfully built ImPPG on the macOS + Xcode outlined in issue subject

$ mkdir build
$ cd build
$ CXXFLAGS="-I/usr/local/include -std=c++17" cmake -G "Unix Makefiles" -DCMAKE_BUILD_TYPE=Release ..
$ make -j8
$ make install
$ imppg

Is this worth mentioning in the README? Of course this env var may not be needed in older (or future newer) versions. I can make a PR if so.