Coder Social home page Coder Social logo

Comments (7)

timo-klarshift avatar timo-klarshift commented on July 24, 2024 1

I was not fully sure and it seemed to work in my tests. Thanks for fixing so quickly!

from portaudio.

timo-klarshift avatar timo-klarshift commented on July 24, 2024
 func getBuffer(s *reflect.SliceHeader, p *C.PaStreamParameters) (unsafe.Pointer, int, error) {
 	if p.sampleFormat&C.paNonInterleaved == 0 {
 		n := int(p.channelCount)
 		if s.Len%n != 0 {
 			return nil, 0, fmt.Errorf("length of interleaved buffer not divisible by number of channels")
 		}
 		return unsafe.Pointer(s.Data), s.Len / n, nil
 	} else {
 		if s.Len != int(p.channelCount) {
 			return nil, 0, fmt.Errorf("buffer has wrong number of channels")
 		}
-		buf := make([]uintptr, s.Len)
+		buf := make([]reflect.SliceHeader, s.Len)
 		frames := -1
-		sp := s.Data
+		sp := (*[1 << 30]reflect.SliceHeader)(unsafe.Pointer(s.Data)) // convert s.Data to a SliceHeader slice
 		for i := range buf {
-			ch := (*reflect.SliceHeader)(unsafe.Pointer(sp))
+			ch := &sp[i]
 			if frames == -1 {
 				frames = ch.Len
 			} else if ch.Len != frames {
 				return nil, 0, fmt.Errorf("channels have different lengths")
 			}
-			buf[i] = ch.Data
+			buf[i] = *ch
-			sp += unsafe.Sizeof(reflect.SliceHeader{})
 		}
-		return unsafe.Pointer(&buf[0]), frames, nil
+		return unsafe.Pointer(&buf[0].Data), frames, nil
 	}
 }

from portaudio.

timo-klarshift avatar timo-klarshift commented on July 24, 2024

I am running Go 1.20.4

from portaudio.

gordonklaus avatar gordonklaus commented on July 24, 2024

Thanks for the report!

from portaudio.

timo-klarshift avatar timo-klarshift commented on July 24, 2024

May I ask why you are not creating fixed Tags for this repo?

from portaudio.

gordonklaus avatar gordonklaus commented on July 24, 2024

I guess it never crossed my mind. It's not a very active repo. What's the benefit?

from portaudio.

timo-klarshift avatar timo-klarshift commented on July 24, 2024

To use it with clear versions as a dependency without having to specify commit hashes in go.mod. It's just easier to communicate a specific version. But it's not a big deal either..

from portaudio.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.