Coder Social home page Coder Social logo

gnome-integration-team / firefox-gnome Goto Github PK

View Code? Open in Web Editor NEW
252.0 252.0 139.0 10.73 MB

GNOME 3 theme for Firefox (previously known as Adwaita)

License: Mozilla Public License 2.0

Python 8.43% CSS 90.84% JavaScript 0.58% Shell 0.04% Java 0.12%

firefox-gnome's People

Contributors

0rax0 avatar ba3r avatar brutor avatar circlecode avatar frnogueira avatar garrett avatar jackinloadup avatar jacobwb avatar marb avatar piotrdrag avatar pulb avatar seleznev avatar yorunohikage avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

firefox-gnome's Issues

Spinner/throbber looks a bit out of place

The standard spinner is out of place. It would be nice to have something more GNOMEy.

This requires making APNGs... so it's not entirely trivial. (Gimp does not support APNGs, for instance.)

Tabs on top looks quite strange

When tabs are on top (as will be the case for most people using the theme), things look very strange. The tabs are brown like the toolbar.

Tab overflow

I have been working on what happens when there are too many tabs. Previously, I just disabled tab overflow. Now, I have re-enabled it once there are a ridiculous amount of tabs.

Please test the taboverflow remote branch:
https://github.com/adwaita-firefox-team/adwaita-firefox/tree/taboverflow

If you are using git_remote_branch @ https://github.com/webmat/git_remote_branch, you should be able to simply use grb track taboverflow to get the branch locally.

Otherwise, run: git fetch && git checkout -tb taboverflow origin/taboverflow

Remove unnecessary files in theme/chrome/

There are probably still unneeded files in theme/chrome/. The directories theme/modules, theme/components and theme/modules of the original omni.jar firefox 4 archive have been removed already.

Supported version needs bumping

Hi guys,
The supported version number needs bumping again.
Currently the aurora channel is at 8.0a2 and the nightly channel is at 9.0a1.
The theme doesn't seem to have any problems with either :)

Scrollbar zooms with the page

Hello,

I greatly appreciate your work on this theme, it's a nice job.

Yet I noticed that when I zoom in or out within a web page, the scrollbar (if presents) is affected and gets bigger or smaller. At the maximum zoom rate it almost reaches one cm wide.

I did't notice this behavior with the firefox default theme for example.

Thanks very much!

Nicolas.

Bump supported version to 6.0a2

Currently the max supported version is 6.0a1, however the current version on the aurora channel is 6.0a2.
I am currently using this theme on 6.0a2 and can confirm that it works.

Tab spacing is incorrect

While I don't like the tab spacing in Epiphany (too much padding on the sides, especially on the right side), this Firefox theme does not have enough (most notably on the sides). It doesn't need to conform 100% with the way GTK+ does things, but having a little bit more space on the left (especially) and right will make things look better.

Support user themes

Right now, we don't do a very good job supporting user themes. We should probably add support for this.

I imagine it means making the background tabs a bit translucent among other things.

GNOME 3.4 changes

There are visual changes in GNOME 3.4.

When should we release these?

I can start development on them. The things I've noticed so far:
* Different scrollbar
* Updated tabs (especially a darker unselected tab)

  • Different style for widgets of unfocused windows (not sure how we'd handle this...)

There are probably more changes as well, but these are the ones that are immediately obvious.

Upgrade to new Firefox 10+ theme

I've made a branch called upgrade-to-10 that pulls in a lot of changes from the Firefox 10 theme. We need to support the new inspector and some of the changes of the UI (such as add-ons).

The branch is probably buggy, as it was a huge diff, so I'll work on it some more during the bus trip to and/or from FOSDEM.

Also, it may be a good idea to make sure nightly builds work too. (It would be interesting to see if there have been differences made from 10 to nightly.)

New content tab highlighting

I think the new tab highlighting could be improved. I had a bolder version before, but made it more subtle. Even still, I'm not quite satisfied with it and am open to changing it further.

What way would you improve it?

Do you think the color (yellow, currently) is correct?

Tab bar background doesn't change when the window is unfocused

Select another window and the background color on the tab bar does not look correct.

I think the Mac OS X theme handles changing the color on the tab bar for unfocused windows (so, the Mac theme may be a starting point to figure out how it is done), but I'd have to reboot to check again to see if that is the case.

active scroll area smaller than usual?

To scroll webpages, I am used to move the cursor to the right edge of the screen, then hold down and move the cursor as desired.

This works with the Default theme of Firefox. With Adwaita Firefox, I have to move the cursor about three pixels to the left of the screen edge for the scrollbar to register the click. Would it be possible to change it back, so you can scroll at the edge again? Thanks for considering.

Affects both the Adwaita 11.1 xpi and the version on addons.mozilla.org.
Firefox 11
GNOME 3.2

Forces single row tab bar when using Tab Mix Plus

Tab Mix Plus allows tabs to reflow into multiple rows if they can't comfortably fit into a single row. Adwaita for Firefox forces all tabs to be in a single row, ignoring preferences set in Tab Mix Plus.

How to reproduce:

  1. Install Tab Mix Plus.
  2. Go to Tools -> Tab Mix Plus Preferences -> Display -> When tabs don't fit width -> Multi-row. Open several tabs so that they appear in multiple rows.
  3. Install the Adwaita for Firefox extension and restart Firefox.
  4. Tabs that were appearing in multiple rows now appear in a single row.

Theme is derived from Firefox 4, therefore does not have Firefox 5 improvements

  • The tab mouse-out resize fix is not included (https://bugzilla.mozilla.org/show_bug.cgi?id=465086)
  • The about box displays Firefox 4.0.1, which is more than a bit confusing
  • I'm sure there are other minor issues... as there were probably other theme-related bugfixes in Firefox 5

I'll look into porting the theme to Firefox 5 for all the fixes.

(Also, figuring out which files are correct for a theme and which are unnecessary will help us in the future too. Perhaps the about box issue stems from this.)

Scrollbar's clickable area does not extend to the edge

One cannot maximize the browser and click the scrollbar from the screen edge. I have ideas on how to fix this.

Basically, Firefox supports multiple borders. One of them can either be transparent or the same color as the background. That should make the scrollbar thumb clickable, I think.

Versioning scheme

Should we switch to a different versioning scheme, now that Firefox has?

I think it might be nice to do it like so:

firefox-theme-base.minor-version.bugfix

In this case, our current theme version would be 10.1, if we released what we have today.

If we don't pull in the changes from Firefox 11 (for whatever reason), but made a bugfix, it'd be 10.1.1. If we added new features, it'd be 10.2. If we upgrade to the base theme of Firefox 11, it'd be 11.1.

Alternatively, we could just do:

firefox-theme-base.our-version

...And we'd bump our version per release, regardless of feature or bugfix. In this model, we might just have the .0 versions implied, and then reset the counter each time we upgrade to the latest theme release.

What do you think?

The textboxes should indicate if they are focused or not.

Hello,

As I was saying on G+, there should be some kind of indication when a textbox is focused. Since I'm a newbie when it comes to dealing with Git and commits, I'll paste my changes here. Sorry of the hassle. :)

urlbar[focused="true"], .searchbar-textbox[focused="true"] {

border: 1px solid #3d95e7;
}

New screenshot

We need a new screenshot for the theme.

Perhaps we need to show both tabs on top and tabs on bottom?

"Floating" app tabs during tab overflow

When there are way too many tabs (a situation most of us get into from time to time), any app tabs that are made become smaller and float to the left, detatched from the tab bar. They also do not overlap as usual.

I need to see if we're inheriting this from upstream or if this is specific to our theme. Regardless of where the bug appears, we may be able to correct it. (Although, if this is an upstream bug, then we'll have to take care that things don't break in the future, but we'll cross that bridge when we get there, if that is indeed the case...)

Dark version

With the coming of Gnome 3.2 and an actual working version of the dark Adwaita, will there be a dark version of this theme?

tab-bar is prevented to become scrollable

With Adwaita tab-bar DOES NOT become scrollable while in the default theme it's ok.
Checked with FF 10.0.2 and all extensions and plugins off on a clear profile. Ctrl+t many times.

Thunderbird theme

We should look into making a Thunderbird 5 theme based on this Firefox theme as well.

Default Window Management Buttons in Full Screen Mode

When entering the full screen mode in Firefox with F11, the topmost toolbar (tab-toolbar if 'Tabs on Top' is selected, otherwise navigation-toolbar) gets the little Icons to 'Minimize', 'Restore' and 'Close' the window. Other GNOME-3 applications that support a full screen mode show a button to leave it, instead. Compare EOG and Evince.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.