Coder Social home page Coder Social logo

Comments (10)

marb avatar marb commented on May 16, 2024

Scrollbars should be defined in chrome/global/scrollbars.css. After adding chrome/global line in chrome.manifest, Firefox overrides default interface style with values form chrome/global css files. But there is nothing there besides scrollbars, and whole firefox becomes unstyled mess.

from firefox-gnome.

garrett avatar garrett commented on May 16, 2024

Just a thought: Given the simplicity of the scrollbar, it would probably be best to theme it using pure CSS instead of using images. We could use things like border-radius.

However, given the way XUL sometimes works, I'm not 100% sure if this is possible. Sometimes things you think will work do not, and sometimes things may work.

Also, it would be nice if we could somehow make the width of the scrollbar inherit from the standard width of the GTK+ theme... if it could be possible to do so.

from firefox-gnome.

marb avatar marb commented on May 16, 2024

About the scrollbars width - I know. But as I had this narrower images already done, I used them to check if it will work, and as a starting point.

Scrollbars made only with CSS - good idea, but right now I also don't know is it possible.

from firefox-gnome.

garrett avatar garrett commented on May 16, 2024

I can look into it further too... but as for now, I've been using a GTK+2 theme that looks like the GTK+3 one to get the Adwaita look for my scroolbars.

As it's not handled by default, I do think we probably should handle this in the theme.

If GNOME 3.2 does include a better GTK+2 theme (with proper scrollbars), then we can yank support for it in the future (unless it really looks/acts native — which it should, anyway).

from firefox-gnome.

marb avatar marb commented on May 16, 2024

It looks like it can be done with CSS only - I'm working on it.
But yeah, we should use native scrollbars when official GTK+2 theme will be fixed.

I've tried Aldabra theme for GTK+2 but it has issues, and even if it would be perfect, many people don't use it or don't know about it.

from firefox-gnome.

garrett avatar garrett commented on May 16, 2024

I agree on all counts. (:

Let me know if you want me to help you out.

from firefox-gnome.

marb avatar marb commented on May 16, 2024

Scrollbars are ready.

The biggest problem for me right now is git ;] I never used it and I made some mistakes with commits, etc, and I don't know how to resolve it. Should I request to pull everything and You review my commits and merge good ones?

from firefox-gnome.

garrett avatar garrett commented on May 16, 2024

If it's at a working state, I can do a single commit as a squashed merge.

from firefox-gnome.

pulb avatar pulb commented on May 16, 2024

(I commented on the <a "href=https://github.com/adwaita-firefox-team/adwaita-firefox/pull/25" >pull request itself)

from firefox-gnome.

garrett avatar garrett commented on May 16, 2024

I'm closing this, as we have a correct looking scrollbar now. Thanks! (:

from firefox-gnome.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.