gnieto / mulint Goto Github PK

Hi, thank you for writing this linter, as I could not find anything similar anywhere else!

I notice that mulint seems to only traverse function calls that are written as simple statements where the return value is not used. So if a function call is used in an expression then mulint will ignore it.

For example, mulint can detect this deadlock:

type someStruct struct {
  m sync.RWMutex
}

func (s *someStruct) A() {
  s.m.RLock()
  s.B()
  s.m.RUnlock()
}

func (s *someStruct) B() bool {
  s.m.RLock() // This is a recursive lock and it should be detected by this tool
  s.m.RUnlock()
  return true
}

...but not this one:

type someStruct struct {
  m sync.RWMutex
}

func (s *someStruct) A() {
  s.m.RLock()
  v := s.B()           // ***** This is the only difference. *****
  fmt.Println(v)
  s.m.RUnlock()
}

func (s *someStruct) B() bool {
  s.m.RLock() // This is a recursive lock and it should be detected by this tool
  s.m.RUnlock()
  return true
}

$ go get -u github.com/gnieto/mulint

go: github.com/gnieto/mulint upgrade => v0.0.0-20180313231918-24ec3193fbeb
go: finding module for package github.com/GoASTScanner/gas
go: found github.com/GoASTScanner/gas in github.com/GoASTScanner/gas v0.0.0-20200401082031-e946c8c39989
go: github.com/gnieto/mulint imports
github.com/gnieto/mulint/mulint imports
github.com/GoASTScanner/gas: github.com/GoASTScanner/[email protected]: parsing go.mod:
module declares its path as: github.com/securego/gosec
but was required as: github.com/GoASTScanner/gas

golangci/golangci-lint#1507