Coder Social home page Coder Social logo

Comments (6)

cmdcolin avatar cmdcolin commented on September 27, 2024

if you are able to supply the file you are testing on it may help. i can't reproduce this on my sample file, but don't doubt something could be wrong

the ranges code is definitely one of the more legacy parts of the codebase, i didn't try to refactor it at all when refactoring this module out of our jbrowse 1 codebase so would be happy to review/modernize it at some point

from bbi-js.

cmdcolin avatar cmdcolin commented on September 27, 2024

any update? having the file may be easiest if you can send it, feel free to email at [email protected]

from bbi-js.

guillemsegura avatar guillemsegura commented on September 27, 2024

Hi Colin,

Apologies for the delay. We were trying to figure out what was causing the original issue. We found that the files that have the chromosomes sorted lexicographically (i.e., chr1, chr10, chr11) don't have the issue, whereas the ones that have the chromosomes sorted by number (i.e., chr1, chr2, chr3) will show the error.

The ones with the error will have multiple values in recurOffsets in block-view.js and will go into the following code:

if (recurOffsets.length > 0) {
      cirFobRecur(recurOffsets, level + 1);
}

and inside the method cirFobRecur, it will reach the union method that's causing the error:

spans = spans.union(blockSpan);

example_bigwig_sorted_without_error_small.bw.zip
example_bigwig_unsorted_with_error_small.bw.zip

from bbi-js.

cmdcolin avatar cmdcolin commented on September 27, 2024

thanks for the examples! now that you mention the sorting, I remember that another user ran into this same issue here GMOD/jbrowse-components#4168

from bbi-js.

cmdcolin avatar cmdcolin commented on September 27, 2024

I published a new version (4.0.4) that appeared to fix the usage for the example file you added. The ranges code was simplified so that it should be less bug prone now. Let me know if that works :)

from bbi-js.

guillemsegura avatar guillemsegura commented on September 27, 2024

Hi Colin,

That works! Thanks for the quick response and fix :)

from bbi-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.