Coder Social home page Coder Social logo

Comments (4)

julien avatar julien commented on June 12, 2024 1

Hey @artkiver,

I had the same issue and haven't taken the time to submit a pull request, but here's a patch you might want to try.

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 2f3209c..d40d4ae 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -50,7 +50,12 @@ if (APPLE OR WIN32)
   ############################################################################
   # MacOS
   if (APPLE)
-    set(CMAKE_OSX_ARCHITECTURES x86_64)
+    if (${CMAKE_SYSTEM_PROCESSOR} MATCHES "x86_64")
+      set(CMAKE_OSX_ARCHITECTURES x86_64)
+    elseif (${CMAKE_SYSTEM_PROCESSOR} MATCHES "arm64")
+      set(CMAKE_OSX_ARCHITECTURES arm64)
+    endif()
+
     set(CMAKE_FIND_FRAMEWORK LAST)
     set(CMAKE_XCODE_ATTRIBUTE_CLANG_CXX_LANGUAGE_STANDARD "c++14")
     set(CMAKE_XCODE_ATTRIBUTE_CLANG_CXX_LIBRARY "libc++")

from bonzomatic.

artkiver avatar artkiver commented on June 12, 2024

Hey @artkiver,

I had the same issue and haven't taken the time to submit a pull request, but here's a patch you might want to try.

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 2f3209c..d40d4ae 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -50,7 +50,12 @@ if (APPLE OR WIN32)
   ############################################################################
   # MacOS
   if (APPLE)
-    set(CMAKE_OSX_ARCHITECTURES x86_64)
+    if (${CMAKE_SYSTEM_PROCESSOR} MATCHES "x86_64")
+      set(CMAKE_OSX_ARCHITECTURES x86_64)
+    elseif (${CMAKE_SYSTEM_PROCESSOR} MATCHES "arm64")
+      set(CMAKE_OSX_ARCHITECTURES arm64)
+    endif()
+
     set(CMAKE_FIND_FRAMEWORK LAST)
     set(CMAKE_XCODE_ATTRIBUTE_CLANG_CXX_LANGUAGE_STANDARD "c++14")
     set(CMAKE_XCODE_ATTRIBUTE_CLANG_CXX_LIBRARY "libc++")

I tested this and it seems to have done the trick! No more prompt for Rosetta(2) to be installed!

I can prep and submit a PR if you prefer?

from bonzomatic.

artkiver avatar artkiver commented on June 12, 2024

Ah, nevermind! I see you already submitted a PR here!

#177

LGTM!

Thanks!

from bonzomatic.

artkiver avatar artkiver commented on June 12, 2024

Merge 84ed5e7 closes this issue.

from bonzomatic.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.