freshlybrewedcode / pymee Goto Github PK

An Attribute in Homee can have options.
The currently known are:

• can_observe (list of attribute types)
• observes (list ob attribute IDs)
• observed_by (list ob attribute IDs)
• history (dict {'day': ,'week': ,'month': , 'stepped': } )
• automations (list of automation names)
• reverse_control_ui (bool)

At least the last one is useful for other applications acessing Homee. So it is desired to expose them in pymee.

There are two possible approaches:

Option 1

Iterate over the options and convert the dict to an object:

def __init__(self, attributeOptions):
    for key, value in attributeOptions.items():
        setattr(self, key, value)

Option 2

Add getters for the known possible options and return empty values if they don't exist.

def __init__(self, attributeOptions):
    self._data = attributeOptions

@property
def can_observe(self) -> list:
    if "can_observe" in self._data:
        return self._data["can_observe"]
...

@FreshlyBrewedCode: Since it is your project, I want to get your opinion on which approach to use before I do a pull request

Example code of an Attribute with options:

{
  'id': 38,
  'node_id': 3,
  'instance': 0,
  'minimum': 0,
  'maximum': 4, // 0 = Closed; 1 = Open; 2 = Stop; 3 = Closing; 4 = Opening
  'current_value': 1.0,
  'target_value': 1.0,
  'last_value': 4.0,
  'unit': 'n%2Fa',
  'step_value': 1.0,
  'editable': 1,
  'type': 135, // UP_DOWN
  'state': 1,
  'last_changed': 1687175680,
  'changed_by': 1,
  'changed_by_id': 0,
  'based_on': 1,
  'data': '',
  'name': '',
  'options': {
      'can_observe': [300],
      'observes': [75],
      'reverse_control_ui': True,
      'automations': ['toggle']
}

After the last update, my HA logs show the following:

2023-06-26 13:01:20.559 ERROR (MainThread) [pymee] An error occurred: invalid state
2023-06-26 13:01:25.918 ERROR (MainThread) [pymee] An error occurred: 'list' object is not an iterator

The second line gets repeated then every 5 seconds for about 20 minutes
Not sure yet where it comes from - I keep investigating.

The upload to PyPi fails in the release process:

400 User 'FreshlyBrewedCode' does not have a verified primary email address. Please add a verified primary email before attempting to upload to PyPI. See https://pypi.org/help/#verified-email for more information.

Hi,

I'm planning some bigger changes to pymee in the near future:

• support more message types (error, user, settings)
• use enum classes in const.py
• refactor code so HA integration does not need to use private properties

Do you still want to be kept in the loop and do it via Pull requests -> release by you or shall we do it the same way as with the HA integration?