Coder Social home page Coder Social logo

Comments (2)

FreshlyBrewedCode avatar FreshlyBrewedCode commented on July 2, 2024

Thanks for the detailed explanation.

So from my point of view HomeAttribute (or really any thing in model.py) is only a convenience wrapper around the data returned by the API. It is really just used to "strong type" the data so that it is easier to work with (intelisense etc.).
Which is why I would personally go with your Option 2. I would add a new class HomeeAttributeOptions that strong types all the options and return it from HomeeAttribute:

@property
def options(self) -> HomeeAttributeOptions:
    return HomeeAttributeOptions(self._data['options'])

or just assign self.options in __init__.

If an option is missing users could still access them via the raw data.

from pymee.

Taraman17 avatar Taraman17 commented on July 2, 2024

Thank you for the quick reply.

Most interestingly the last part is exaclty my approach - this is how it looks like in my draft:

@property
def options(self) -> HomeeAttributeOptions:
    """The options collection of the attribute. Optional, not on every attribute."""
    return HomeeAttributeOptions(self._data["options"])

;-)

from pymee.

Related Issues (2)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.