Coder Social home page Coder Social logo

Comments (8)

yanntm avatar yanntm commented on June 3, 2024 1

Ok thanks ! I'm kind of into formal verification, so I tend to trust the specifications too much, I mean Brie does get a lot smellier each day in the fridge, and I live in France :) So, it fits.

from gildedrose-refactoring-kata.

emilybache avatar emilybache commented on June 3, 2024

Well spotted! Yes the code does some things that aren't fully documented. It's supposed to be legacy code after all 👍 You can basically assume that anything the code does is correct. It's in production, the Gilded Rose Inn is using it. If there is a conflict with the requirements, trust the code in preference.

Happy you had a go at the exercise!

Emily

from gildedrose-refactoring-kata.

mikalziane avatar mikalziane commented on June 3, 2024

Good to know about this hidden "feature" Emily. Is it possible that someone updates the requirements then?
I am also wondering if the different implementations (in several languages) share the exact same requirements. Unless I misunderstood something your reply suggests that this is not the case or someone would have to make sure all the implementations agree.

from gildedrose-refactoring-kata.

emilybache avatar emilybache commented on June 3, 2024

No, the requirements are perfect for the excercise exactly as they are.

from gildedrose-refactoring-kata.

mikalziane avatar mikalziane commented on June 3, 2024

I have problems understanding the exercise.
You say "if there is a conflict with the requirements, trust the code in preference."
and " the requirements are perfect for the exercise exactly as they are."
Obviously they are not "perfect" if code supersedes them so I have to understand what "perfect for the exercise" means
unless the point is for the requirements to be misleading on purpose. Is this the case? If they are not why keep inconsistency between code and the requirements?

from gildedrose-refactoring-kata.

emilybache avatar emilybache commented on June 3, 2024

Yes, this is an exercise that is supposed to be like real life. The requirements and code and any inconsistency between them is deliberate and part of the exercise.

from gildedrose-refactoring-kata.

mikalziane avatar mikalziane commented on June 3, 2024

OK then, thank you for the clarification. I'll take the "requirements" as a mere comment on the code then as they are supposed to be in real life ;-)

from gildedrose-refactoring-kata.

soryy708 avatar soryy708 commented on June 3, 2024

It was a surprising discovery, but I see how it makes sense from the requirements as written.

"Aged Brie" actually increases in Quality the older it gets
Once the sell by date has passed, Quality degrades twice as fast

These two specifications together mean Aged Brie gets 2 points once the sell by date has passed.

But hey, spoilers!

from gildedrose-refactoring-kata.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.