Coder Social home page Coder Social logo

Comments (2)

emilybache avatar emilybache commented on June 11, 2024

The main branch has tests already, with the tool 'texttest'. Almost all the language versions have a TextTestFixture, but not all of them are configured to actually be runnable with texttest. For that you need an entry in the file texttests/config.gr specifying how to execute the TextTestFixture.

Plus, the C# version has a test included that uses Approvals. I haven't done the same for the other translations, at the time when that one was contributed, there wasn't an Approvals library for other languages. So it's a bit of an anomaly.

I do think it's a useful part of the exercise to try writing your own tests first before looking at the provided tests. I would prefer the texttests and the Approvals tests were in a 'with_tests' branch. I haven't had the energy to do this change, as you point out, it's a lot of work.

At present I think I am content with the status quo. However, your help with an entry for php in the 'config.gr' could be useful, if you want to try out texttest yourself?

from gildedrose-refactoring-kata.

Pen-y-Fan avatar Pen-y-Fan commented on June 11, 2024

PHP updated with ApprovalTest and accepted.
Closing the question.
Thanks 👍

from gildedrose-refactoring-kata.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.