Comments (2)
The main branch has tests already, with the tool 'texttest'. Almost all the language versions have a TextTestFixture, but not all of them are configured to actually be runnable with texttest. For that you need an entry in the file texttests/config.gr specifying how to execute the TextTestFixture.
Plus, the C# version has a test included that uses Approvals. I haven't done the same for the other translations, at the time when that one was contributed, there wasn't an Approvals library for other languages. So it's a bit of an anomaly.
I do think it's a useful part of the exercise to try writing your own tests first before looking at the provided tests. I would prefer the texttests and the Approvals tests were in a 'with_tests' branch. I haven't had the energy to do this change, as you point out, it's a lot of work.
At present I think I am content with the status quo. However, your help with an entry for php in the 'config.gr' could be useful, if you want to try out texttest yourself?
from gildedrose-refactoring-kata.
PHP updated with ApprovalTest and accepted.
Closing the question.
Thanks 👍
from gildedrose-refactoring-kata.
Related Issues (20)
- dotnet core test is not running on Windows plateform HOT 3
- Add Gilded Rose kata in JavaScript with Jest HOT 2
- texttest quality values for Conjured Mana Cake incorrect HOT 5
- Aged Brie getting 2 points per time step ? HOT 8
- octave / matlab ? HOT 5
- cpp cpptexttest shows unidiomatic C++ HOT 2
- TextTestHarness vs Unit treatment of items HOT 2
- Java version seems to update tickets incorrectly HOT 3
- Error on stdout.gr for conjured items expected quality HOT 1
- Duplication HOT 2
- Link to Better Code Hub / BCH compliance badge broken in README.md HOT 1
- texttest conjured items HOT 2
- [cpp] tests not compiling for Catch2
- csharpcore Acceptance Tests stay blue (not executed) HOT 8
- texttest_fixture.py Doesn't follow requirements? HOT 1
- [PHP] Item class should not be final HOT 1
- Conjured items are under specified
- Rider doesn't detect unit tests in csharpcore exercise HOT 5
- Why are there 3 c# projects? HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gildedrose-refactoring-kata.