Comments (3)
I fixed this by updating the test to use the Approvals framework. The test still fails, but the idea is that to fix it you have to learn about the Approvals framework.
from gildedrose-refactoring-kata.
Not thrilled that I need to learn the Approvals test framework at the moment as I'm evaluating someone and neither of us know why the test fails, even after reading the docs. I guess if I wanted to learn Approval test framework I'd go to their website. I do appreciate that you maintain this repo but I don't think the 'test framework doesn't work' is helpful since it works in all the other repos AFIK.
from gildedrose-refactoring-kata.
There is no need for you to learn the Approvals framework to do this exercise. There is a failing unit test that doesn't use Approvals that you can start from instead. You can write your own tests, that is a perfectly valid way to use this exercise.
from gildedrose-refactoring-kata.
Related Issues (20)
- Add Gilded Rose kata in JavaScript with Jest HOT 2
- Create `with_tests` branch HOT 2
- texttest quality values for Conjured Mana Cake incorrect HOT 5
- Aged Brie getting 2 points per time step ? HOT 8
- octave / matlab ? HOT 5
- cpp cpptexttest shows unidiomatic C++ HOT 2
- TextTestHarness vs Unit treatment of items HOT 2
- Java version seems to update tickets incorrectly HOT 3
- Error on stdout.gr for conjured items expected quality HOT 1
- Duplication HOT 2
- Link to Better Code Hub / BCH compliance badge broken in README.md HOT 1
- texttest conjured items HOT 2
- [cpp] tests not compiling for Catch2
- csharpcore Acceptance Tests stay blue (not executed) HOT 8
- texttest_fixture.py Doesn't follow requirements? HOT 1
- [PHP] Item class should not be final HOT 1
- Conjured items are under specified
- Rider doesn't detect unit tests in csharpcore exercise HOT 5
- Why are there 3 c# projects? HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gildedrose-refactoring-kata.