Comments (7)
I guess I don't understand what you mean.
from ember-test-helpers.
Since we don't really need any special shenanigans to deal with bizarreness in Ember, this sort of thing likely lives in ember-qunit itself.
from ember-test-helpers.
Sorry if this is too cryptic.
https://github.com/rwjblue/ember-qunit/pull/71 introduces a moduleForApp
to wrap
I'd like to push that forward, but it looks like that PR predates the ember-test-helpers
/ ember-qunit
split, so I tried to work it into this repo instead but I hit a wall.
from ember-test-helpers.
We've been toying around with implementing something like this for use in one of our addons. Thus far, we've been writing all the code inside the addon, but with an eye for potentially extracting it out for inclusion into ember-test-helpers
https://gist.github.com/Robdel12/c8470434a5e0ded666db
It's been working really well thus far, but my primary concern is with these lines here https://gist.github.com/Robdel12/c8470434a5e0ded666db#file-test-helper-js-L2-L3
Since this class is embedded into our addon, it has access to the (dummy) application's class and config, but is that going to pose a problem if this code were to live in ember-test-helpers
?
Also, the startApp()
test helper that gets generated by ember-mocha
and ember-qunit
acceptance-test blueprints allows passing one-off options to Application.create()
per test. Changing settings suite-wide in environment.js for 'test'
has always been sufficient for us, so we wouldn't miss that, but it might be a problem for others.
from ember-test-helpers.
Unless anybody sees anything obviously flawed with this approach, we'll go ahead and submit the PR.
from ember-test-helpers.
@cowboyd I say go ahead, I have an outstanding PR to ember-cli/ember-cli, but I'm having some trouble with it.
If we could get something working in this repo instead, I think we'd be better off.
from ember-test-helpers.
Added to ember-cli
directly in ember-cli/ember-cli#4692
from ember-test-helpers.
Related Issues (20)
- element doesn't exist on type TestContext HOT 2
- Property 'element' does not exist on type 'TestContext'. ? HOT 2
- `find` and `findAll` examples are swapped
- Cannot find type definition file for 'ember__test-helpers' after upgrading to v2.9.3 HOT 2
- Regression with `find()` generic type HOT 1
- Rethinking helpers for forms input HOT 2
- Observers not triggered in ember acceptance tests
- [proposal] add hooks support to all dom helpers + settled and wait-until
- Upgrade `registerHook` and `runHooks` as official public APIs HOT 4
- `fillIn` does not work with input values that are decorated with the `readonly` helper HOT 1
- [feature request] pass more information back in error scenarios
- `scrollTo` target type inconsistent with other test helpers
- Setup context fails when using ember-data v4 and a custom resolver
- Allow `waitUntil` to accept a callback that returns a promise HOT 1
- Types missing from version 3 HOT 4
- Anomalies in current published version compared to previous versions HOT 5
- Allow Ember v5
- needed infra maintainence
- 3.2.0 Missing `lookup` and `register` on `Owner` type definition HOT 7
- How to refresh current visiting page in Ember Test?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-test-helpers.