Coder Social home page Coder Social logo

Comments (7)

runspired avatar runspired commented on July 18, 2024

I realized there is now an undeclared peer-dependency on @types/ember__owner (or I suppose similar for preview types). Adding this resolved these issues for all but unregister.

tests/main/tests/integration/record-data/record-data-state-test.ts(213,11): error TS2551: Property 'unregister' does not exist on type 'Owner'. Did you mean 'register'?

from ember-test-helpers.

runspired avatar runspired commented on July 18, 2024

Side note for anyone encountering similar upgrade pains: I also discovered when removing the no longer needed legacy test types that these legacy test types had also brought @types/jquery, we were missing this and didn't know.

from ember-test-helpers.

runspired avatar runspired commented on July 18, 2024

full set of required changed we ended up needing to make is here emberjs/data#8630

from ember-test-helpers.

NullVoxPopuli avatar NullVoxPopuli commented on July 18, 2024

this library uses the types from ember-source: https://github.com/emberjs/ember-test-helpers/blob/master/addon/types/dummy/index.d.ts#L1

undeclared peer-dependency on @types/ember__owner

I don't think we want to add that, because the consumer can provide those types.

I could be wrong, but afaik, types are globally available (indexed on module name), and there is no per-package resolving of types, as there is with resolving package dependencies.

from ember-test-helpers.

runspired avatar runspired commented on July 18, 2024

I don't think we want to add that, because the consumer can provide those types.

Seems like a missing pnpm feature for types-only peer-dependency ;)

from ember-test-helpers.

runspired avatar runspired commented on July 18, 2024

this library uses the types from ember-source

But it is supposed to be more broadly compatible and given no announcement of stable types from ember-source has been made (I notice in what you linked a claim that 5.1 has stable type now, but the release post makes no mention of this) I wouldn't have expected updating ember-test-helpers to have forced an upgrade of all types for Ember.

from ember-test-helpers.

NullVoxPopuli avatar NullVoxPopuli commented on July 18, 2024

no announcement of stable types from ember-source

https://github.com/emberjs/ember.js/releases/tag/v5.1.0
https://github.com/ember-learn/ember-blog/pull/1284/files#diff-757a9c497b0a002ae5f535ef6d832c790890c454a56c56cb978294729a12b3ceR29

I don't have comments about the other stuff in your comment, because I don't have the context

from ember-test-helpers.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.