Coder Social home page Coder Social logo

Comments (5)

NullVoxPopuli avatar NullVoxPopuli commented on July 18, 2024 1

I have a fix! #1408

from ember-test-helpers.

MelSumner avatar MelSumner commented on July 18, 2024

So in considering what's changed between the two versions, the file structure is the first thing that comes to mind.

I think we need to move the licenses inside of the addon folder.
But if this was the complete answer, I think we should have seen the CHANGELOG published. This would suggest that there's still something funky going on.

from ember-test-helpers.

fivetanley avatar fivetanley commented on July 18, 2024

Adding to the list of anomalies: It seems that only typescript files are ending up in the tarball published to npm. https://www.npmjs.com/package/@ember/test-helpers?activeTab=code. For version 3.0.2:

Screenshot 2023-06-08 at 15 56 39

This should be full of JS files but it's not. I think that's what's causing the build to fail for this PR (emberjs/ember-qunit#1077). The app tries to pull in the add-on, which works, but because there are no JS files, and there is no ember-cli-typescript configured, no modules for @ember/test-helpers get built/defined, leading to the "no module @ember/test-helpers" error.

from ember-test-helpers.

NullVoxPopuli avatar NullVoxPopuli commented on July 18, 2024

what's goofy is that the prepack script includes build, which generates all the JS
image

But I confirmed that both npm pack and yarn pack, that all the JS files are excluded.

from ember-test-helpers.

MelSumner avatar MelSumner commented on July 18, 2024

Re-opening because npm pack is still revealing that we're missing changelog and license files. I think I know how to fix this, PR incoming.

from ember-test-helpers.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.