Comments (5)
I have a fix! #1408
from ember-test-helpers.
So in considering what's changed between the two versions, the file structure is the first thing that comes to mind.
I think we need to move the licenses inside of the addon folder.
But if this was the complete answer, I think we should have seen the CHANGELOG published. This would suggest that there's still something funky going on.
from ember-test-helpers.
Adding to the list of anomalies: It seems that only typescript files are ending up in the tarball published to npm. https://www.npmjs.com/package/@ember/test-helpers?activeTab=code. For version 3.0.2:
![Screenshot 2023-06-08 at 15 56 39](https://private-user-images.githubusercontent.com/1275021/244532052-d91c3cf9-3481-48f9-9252-9f97b32269cb.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjEyNTMyNTYsIm5iZiI6MTcyMTI1Mjk1NiwicGF0aCI6Ii8xMjc1MDIxLzI0NDUzMjA1Mi1kOTFjM2NmOS0zNDgxLTQ4ZjktOTI1Mi05Zjk3YjMyMjY5Y2IucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcxNyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MTdUMjE0OTE2WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ODk4MDBjMjdkN2Q1MjhmMjBiYzExN2FlNzJmNzI3OTA5YzU0MjE4OWY3ZTgzMjcxYmJhZjliNzljYmQ3MjZkYiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.1rR-bYthcWhtpn2iySUl_m9aMOYa5NymZGt7Ct4MH50)
This should be full of JS files but it's not. I think that's what's causing the build to fail for this PR (emberjs/ember-qunit#1077). The app tries to pull in the add-on, which works, but because there are no JS files, and there is no ember-cli-typescript
configured, no modules for @ember/test-helpers
get built/defined, leading to the "no module @ember/test-helpers" error.
from ember-test-helpers.
what's goofy is that the prepack
script includes build
, which generates all the JS
But I confirmed that both npm pack
and yarn pack
, that all the JS files are excluded.
from ember-test-helpers.
Re-opening because npm pack
is still revealing that we're missing changelog and license files. I think I know how to fix this, PR incoming.
from ember-test-helpers.
Related Issues (20)
- Regression with `find()` generic type HOT 1
- Rethinking helpers for forms input HOT 2
- Observers not triggered in ember acceptance tests
- [proposal] add hooks support to all dom helpers + settled and wait-until
- Upgrade `registerHook` and `runHooks` as official public APIs HOT 4
- `fillIn` does not work with input values that are decorated with the `readonly` helper HOT 1
- [feature request] pass more information back in error scenarios
- `scrollTo` target type inconsistent with other test helpers
- Setup context fails when using ember-data v4 and a custom resolver
- Allow `waitUntil` to accept a callback that returns a promise HOT 1
- Types missing from version 3 HOT 4
- Allow Ember v5
- needed infra maintainence
- 3.2.0 Missing `lookup` and `register` on `Owner` type definition HOT 7
- How to refresh current visiting page in Ember Test?
- Remove old compatibility code
- TypeScript error with `Owner` interface HOT 3
- New app failing to start HOT 2
- Update to ember-cli-babel@8+ to fix a json5 vulnerability HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-test-helpers.