Comments (8)
I think a second render
call should properly tear down the first one first. There seems to be no downside to that, and it will Just Work as expected.
from ember-test-helpers.
#147 added the ability to call clearRender
as needed, but did not add guards or automatically call clearRender
when multiple this.render
calls are made.
In theory I am fine with either, but kinda lean towards automatically calling clearRender
on any subsequent this.render
calls (since multiple this.render
calls "works" today).
from ember-test-helpers.
Thanks for reporting!
@ef4 / @dgeb - Thoughts on this?
from ember-test-helpers.
FWIW it's perfectly possible to have two tests invoke this very same component.
It seems questionable to me if there's value in mixing both render types into one test or if it wasn't a better idea to separate them by default in the component-test blueprint.
from ember-test-helpers.
@dschmidt - Yes, the default blueprint is definitely odd at best (having both block and blockless in the same test). We should definitely fix that (perhaps @trabus recalls why we went this specific way).
from ember-test-helpers.
I believe the intent was actually to show both forms for the consumer to pick one or the other, we obviously weren't clear about it.
from ember-test-helpers.
Cleanup failures are really annoying to debug because it effectively leaks state into subsequent tests.
from ember-test-helpers.
Should be resolved by #155.
from ember-test-helpers.
Related Issues (20)
- Missing types for @glimmer/interfaces HOT 3
- element doesn't exist on type TestContext HOT 2
- Property 'element' does not exist on type 'TestContext'. ? HOT 2
- `find` and `findAll` examples are swapped
- Cannot find type definition file for 'ember__test-helpers' after upgrading to v2.9.3 HOT 2
- Regression with `find()` generic type HOT 1
- Rethinking helpers for forms input HOT 2
- Observers not triggered in ember acceptance tests
- [proposal] add hooks support to all dom helpers + settled and wait-until
- Upgrade `registerHook` and `runHooks` as official public APIs HOT 4
- `fillIn` does not work with input values that are decorated with the `readonly` helper HOT 1
- [feature request] pass more information back in error scenarios
- `scrollTo` target type inconsistent with other test helpers
- Setup context fails when using ember-data v4 and a custom resolver
- Allow `waitUntil` to accept a callback that returns a promise HOT 1
- Types missing from version 3 HOT 4
- Anomalies in current published version compared to previous versions HOT 5
- Allow Ember v5
- needed infra maintainence
- 3.2.0 Missing `lookup` and `register` on `Owner` type definition HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-test-helpers.