Coder Social home page Coder Social logo

Comments (8)

ef4 avatar ef4 commented on August 16, 2024 1

I think a second render call should properly tear down the first one first. There seems to be no downside to that, and it will Just Work as expected.

from ember-test-helpers.

rwjblue avatar rwjblue commented on August 16, 2024 1

#147 added the ability to call clearRender as needed, but did not add guards or automatically call clearRender when multiple this.render calls are made.

In theory I am fine with either, but kinda lean towards automatically calling clearRender on any subsequent this.render calls (since multiple this.render calls "works" today).

from ember-test-helpers.

rwjblue avatar rwjblue commented on August 16, 2024

Thanks for reporting!

@ef4 / @dgeb - Thoughts on this?

from ember-test-helpers.

dschmidt avatar dschmidt commented on August 16, 2024

FWIW it's perfectly possible to have two tests invoke this very same component.
It seems questionable to me if there's value in mixing both render types into one test or if it wasn't a better idea to separate them by default in the component-test blueprint.

from ember-test-helpers.

rwjblue avatar rwjblue commented on August 16, 2024

@dschmidt - Yes, the default blueprint is definitely odd at best (having both block and blockless in the same test). We should definitely fix that (perhaps @trabus recalls why we went this specific way).

from ember-test-helpers.

trabus avatar trabus commented on August 16, 2024

I believe the intent was actually to show both forms for the consumer to pick one or the other, we obviously weren't clear about it.

from ember-test-helpers.

yaymukund avatar yaymukund commented on August 16, 2024

👍 this should be fixed.

Cleanup failures are really annoying to debug because it effectively leaks state into subsequent tests.

from ember-test-helpers.

rwjblue avatar rwjblue commented on August 16, 2024

Should be resolved by #155.

from ember-test-helpers.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.