Coder Social home page Coder Social logo

triangulator optimization about manifold HOT 10 CLOSED

pca006132 avatar pca006132 commented on July 3, 2024
triangulator optimization

from manifold.

Comments (10)

kintel avatar kintel commented on July 3, 2024 2

Thx - looks very promising so far!

from manifold.

elalish avatar elalish commented on July 3, 2024 1

Yeah, that sounds good. And actually, I think Delaunay cost should work too - we only care within a bounded region: Delaunay only matters for points closer to the edge midpoint than its half-length. So we should still be able to safely screen out more distant points with BHV.

from manifold.

pca006132 avatar pca006132 commented on July 3, 2024 1

https://github.com/elalish/manifold/blob/master/src/polygon/src/polygon.cpp

from manifold.

pca006132 avatar pca006132 commented on July 3, 2024

btw wonder if it is possible to move some of the sort by morton code logic into the collider.

from manifold.

elalish avatar elalish commented on July 3, 2024

btw wonder if it is possible to move some of the sort by morton code logic into the collider.

Or in its own header file. Still, it's important the sort the actual underlying data structures, since that gives us cache coherence. So the Morton codes are for more than just the collider.

from manifold.

onlynadeem avatar onlynadeem commented on July 3, 2024

I know how to do triangulator optimization very well, but where to import its source file?

from manifold.

pca006132 avatar pca006132 commented on July 3, 2024

Adding a comment from #751:

Optimizations related to triangulator is interesting, I am open to adding fast paths, but a more general one (e.g. monotone triangulation, but doesn't handle epsilon), and directly into the triangulator rather than limited to extrude.

from manifold.

kintel avatar kintel commented on July 3, 2024

This is starting to hurt for some OpenSCAD usage too. It's also surprisingly slow in debug mode:

  • Manifold debug: 5m50s
  • Manifold release: 12s
  • CGAL constrained delaunay triangulator: 0.3s

^ not very scientific, just measuring OpenSCAD e2e processing time.

from manifold.

elalish avatar elalish commented on July 3, 2024

Yeah, debug mode adds a lot of extra checks - we should probably go through and see how many are necessary. And you do mean just MANIFOLD_DEBUG right? Because actual C++ Debug mode is horrifically slow for some reason.

Yeah, we should get this done - it shouldn't even really be so difficult. What kind of example is this where you see the slowdown? Care to make a TEST of it?

from manifold.

kintel avatar kintel commented on July 3, 2024

The polygon in question is #831 - might be a tad big to add as a performance test

from manifold.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.