Coder Social home page Coder Social logo

Comments (5)

kintel avatar kintel commented on July 23, 2024 1

I opened a PR with the failure case. The precision setting isn't needed, I just inherited the argument from surrounding tests in my first repro.

I experience lots of errors like this in OpenSCAD (first attempt at using the triangulator). This is the most trivial one I could find, but it's probably good to start off fixing this before potentially registering a bunch of duplicates.

from manifold.

elalish avatar elalish commented on July 23, 2024

When we run our tests, we run them with params.intermediateChecks = true, which asserts the manifoldness of each triangulation, and with params.processOverlaps = false, which checks that every triangle is CCW. Those should catch this well before the number of triangles check - would you mind adding this test as a PR; then we should see that behavior on the CI.

This seems like a pretty basic error - I'm surprised our existing corpus doesn't catch it.

from manifold.

elalish avatar elalish commented on July 23, 2024

Not that it should matter, but that's a surprisingly wide precision you've specified - is that necessary to repro?

from manifold.

elalish avatar elalish commented on July 23, 2024

Closing as expected behavior since this is an invalid polygon.

from manifold.

kintel avatar kintel commented on July 23, 2024

Thanks for taking a look - I'll fix my upstream issue and run my larger tests :)

from manifold.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.