Coder Social home page Coder Social logo

Comments (4)

harmanpa avatar harmanpa commented on July 3, 2024 1

It turned out that the only cause of this was that meshRelation_.numProp was not set in Manifold::Impl::GatherFaces while the vertProperties and properties were. However I've added a test and associated test utility (PR incoming) to check the properties in a resulting mesh match those set via SetProperties.

from manifold.

pca006132 avatar pca006132 commented on July 3, 2024

Probably a bug because decompose was there before vertex properties.

from manifold.

harmanpa avatar harmanpa commented on July 3, 2024

I'd be happy to try to implement and test a solution, do you know of anywhere in the code that also filters the vertex properties by index that might be similar @pca006132 ?

from manifold.

elalish avatar elalish commented on July 3, 2024

That would be excellent, thanks! It might help to look at CompactProps.

If you get excited about cleaning up Decompose, there's another issue open about it: #745 (comment). Ideally it shouldn't take too much to make Manifold::Decompose act more like CrossSection::Decompose

from manifold.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.