Coder Social home page Coder Social logo

Comments (8)

cclauss avatar cclauss commented on May 20, 2024 1

Agreed. This is blocking our upgrade to Django v5.0.

from django.utils import datetime_safe

https://docs.djangoproject.com/en/5.0/releases/5.0/#features-removed-in-5-0

from django-haystack.

cclauss avatar cclauss commented on May 20, 2024 1

Fixed in #1915 but not yet released to PyPI. Workaround for Django v5.0 deployments:
% pip install git+https://github.com/django-haystack/django-haystack.git

from django-haystack.

michaelmior avatar michaelmior commented on May 20, 2024 1

@cclauss Thanks! Any ETA on a PyPI release?

from django-haystack.

benrxv avatar benrxv commented on May 20, 2024

Django 5.0 is now out, and this issue now officially is a problem

A link to proposed solution is documented above...

from django-haystack.

benrxv avatar benrxv commented on May 20, 2024

Django now uses django.utils.formats.sanitize_strftime_format() to handle what datetime_safe was doing previously.
https://github.com/django/django/blob/0ee2b8c326d47387bacb713a3ab369fa9a7a22ee/django/utils/formats.py#L244

from django-haystack.

cclauss avatar cclauss commented on May 20, 2024

Are you able to create a PR for that?

from django-haystack.

benrxv avatar benrxv commented on May 20, 2024

I'm not certain that haystack needs to sanitize the date strings. Django only seems to do this in a few very specific and important instances, and in one instance, django.utils.feedgenerator, they just replaced datetime_safe with python's native datetime.

from django-haystack.

Albert-2024 avatar Albert-2024 commented on May 20, 2024

Fixed in #1915 but not yet released to PyPI. Workaround for Django v5.0 deployments: % pip install git+https://github.com/django-haystack/django-haystack.git

@cclauss thanks :)

from django-haystack.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.