Issue when filtering by a boolean field in elasticsearch7 about django-haystack

[dchaplinsky]

@toastdriven @acdha could you please take a look into it?

[kingbuzzman]

Having the same issue now, any update?

[febsn]

Same problem here.

[bartTC]

Failed to query Elasticsearch using 'OR title:(pdf) OR keywords:("pdf") OR id:(pdf)) AND NOT (login_required:(True)))': 
...
Can't parse boolean value [True], expected [true] or [false]

You can workaround this, if you don't like to monkeypatch. Just don't pass a boolean. Watch what is passing the boolean, in my case it was login_required.

I changed the corresponding field to hold an integer

login_required = indexes.BooleanField(default=False) # to
login_required = indexes.IntegerField(default=0)

And the related queryset;

    def prepare_login_required(self, obj):
        return obj.page.login_required # to
        return 1 if obj.page.login_required else 0
        
    def get_queryset(self):
        queryset = self.form.search()
        if not self.request.user.is_authenticated:
            queryset = queryset.exclude(login_required=True) # to
            queryset = queryset.exclude(login_required=1)
        return queryset

[rascalking]

I'm also seeing an issue going in the other direction, back into bools in query results. Since BooleanField.convert() just returns bool(value), and bool("false") == True, all booleans are always being returned as True.

I had to resort to subclassing BooleanField and overriding convert():

from haystack.fields import BooleanField as _BooleanField

class BooleanField(_BooleanField):
    def convert(self, value):
        if isinstance(value, str):
            return False if value.lower() in ('false', '') else True
        else:
            return super().convert(value)