darthmike / indielib-crossplatform Goto Github PK

Should refactor not to repeat test setup code:

• Entities/animations/surfaces array creation/destruction
• Test entities/animatins/surfaces adding to managers
• ShowGridAreas on/off logic
• Test entities removing from managers when test is finished

This issue has low priority, but it's worth to refactor for future tests creation in an easy way.

Already done by MFK...

This is already done by DarthMike...

After migrating to SDL 2.0 following events are not handled properly:
SDL_MOUSEWHEEL

Keyboard keys (from SDL 1.3):
SDLK_RMETA
SDLK_LMETA
SDLK_LSUPER
SDLK_RSUPER
SDLK_BREAK
SDLK_EURO

rev. 583 fixes SDL_MOUSEWHEEL

Current OpenGL implementation doesn't respect transformation matrix push/pop for blitGridline and blitGridQuad methods if singularly called. These methods nevertheless are intended to use for blitGridAreas (this method does respect matrix balance)

If user of library uses blitGridLine or blitGridQuad they will not function correctly.

Seems like a regression, as this was working before we imported from SVN repo.

Reproduction:

• Run 'manual' tests
• go to test involving text.

All texts contain 'trash'

Already done by DartMike...

This is a bug/task to implement collision processing blitting correctly in OpenGL upon start. Something is amiss because that functionality if disabled at the time of writing this bug.

Need to create a test for this not to see this issue again in the future.

As a side note, tutorial 08 works perfectly on DirectX.

Should be a real ID, it's not portable, specially in different compilers the ugly cast is reported as an error.

See these files:
IND_Entity2dManager.cpp
IND_SurfaceManager.cpp

And search for the text "g_debug->dataInt((int)"

to see the affected lines. Now they are commented out.

Already done by DarthMike...

Run test and you will see that blocked texture is animating properly, but it's not rendering every subtexture in a correct matter.

It seems that it's taking texture data from somewhere else or even from a different texture altogether.

In the Tutorials / Tests the resource paths are relative to the compiled windows binary. Therefore the paths fails loading on linux. We need to move the compiled linux binary to the bin// folder ( and of cause do this for other platforms as well). After this all paths should be changed in the code.

rev. 579 adds code for 'workingpath' handling in every tests, even in unittests, for unix system. Only need to modify makefile to deploy binary to the directory:
/bin/linux

All relative paths consider a 2 level deep hierarchy from where 'resources' directory is.

have partly fixed this issue (rev 624), - Now unittests builds and runs ( but not yet from the /bin/linux path ) . The result yields the following output:

Working path changed to: /home/michael/indielib/linux/tests/unittestsSuccess: 10 tests passed.
Test time: 0.00 seconds.

Not sure if all unittests are run - where can one see where which unittest are included ?

Already done by DarthMike...

Entities are rescaled and shown from further/closer. New viewport should contain all same view.

Actually there's a problem that the viewPort for us is defined as the window size (resolution), so the viewport changes if window resolution changes. Shouldn't be like that, and user could decide viewport size. Now it's automatically assigned to window size.

Description: because of missing or wrong safeguards there is a type definition clash in SDL 1.3. The issue is allready in a SDL bugreport but currently a fix is not ready yet. Read more about here: http://bugzilla.libsdl.org/show_bug.cgi?id=1328

Changed priority to low. Not on our side anyway

This is already done by Darthmike...

May be related to image conversion or scaling.

Check tutorial project IND_Animation

We must support greyscale types. Now they are broken, with TODO comments.

In DirectX renderer, before blitting and calling graphics API, vertexes are checked to see if they are 'visible'. That improves performance, especially in big scenes out of the screen.

See methods for DirectXRenderer which implement this:

• blitWrapSurface
• blitRegionSurface
• blitGrid
• blitSurface

Context creation should be failure-proof and robust enough.

We should submit ticket to FreeImage devs to show them the problem and for them to fix.

Problem is with XCode 4.3:

• gcc compiler is replaced by llvm-gcc. Also sdk paths
• ppc architecture is not supported
• sdk roots replaced for XCode 4.3 (inside sandboxed app)

rev. 558 fixes OSX makefile

Already done by DarthMike...

Some of the filters supplied by Devillib isn't available in Freeimage, these should be reimplemented. Maybe we can use the sourcecode from Devillib if the Devillib License allows it. Remember to give credit if this is the case.

support the .tmx file format.

A parser library have allready been included in the repository (look in dependencies - a new folder is added).

Two classes are added to the engine in the repository: IND_TmxMap and IND_TmxMapManager.

Work that needs to be done:

1. include files in win32 build.
2. more functionality in the advanced tutorial 05
3. fix header include in files IND_TmxMap.h and IND_TmxMapManager.h. Study Ind_image and IND_imageManager to get an idea to how to handle the problem .. maybe a typedef i the solution.

All features related to collision support are disabled for OpenGL renderer:

1. Collision calculations (maybe this should be in math utilities)
2. Collision lines rendering
3. Collision flags (related to 1.)

Already done by DarthMike...

NOTE: Some IND_Image filters are disabled. FreeImage does not support that kind of functionlality. To be implemented by new team members or in version 1.0.

Need to code review public API and check if every method call is checking all error conditions on it's input data:

• NULL pointers
• incoherent data.
• All input char* should be type const

After migrating to SDL 2.0, events are not handled:
SDL_TEXTEDITING, /< Keyboard text editing (composition) */
SDL_TEXTINPUT, /< Keyboard text input /
/ Tablet or multiple mice input device events /
SDL_INPUTMOTION = 0x500, /< Input moved */
SDL_INPUTBUTTONDOWN, /< Input button pressed */
SDL_INPUTBUTTONUP, /< Input button released */
SDL_INPUTWHEEL, /< Input wheel motion */
SDL_INPUTPROXIMITYIN, /__< Input pen entered proximity */
SDL_INPUTPROXIMITYOUT, /*< Input pen left proximity */

/* Joystick events */
SDL_JOYAXISMOTION  = 0x600, /**< Joystick axis motion */
SDL_JOYBALLMOTION,          /**< Joystick trackball motion */
SDL_JOYHATMOTION,           /**< Joystick hat position change */
SDL_JOYBUTTONDOWN,          /**< Joystick button pressed */
SDL_JOYBUTTONUP,            /**< Joystick button released */

/* Touch events */
SDL_FINGERDOWN      = 0x700,
SDL_FINGERUP,
SDL_FINGERMOTION,
SDL_TOUCHBUTTONDOWN,
SDL_TOUCHBUTTONUP,    

/* Gesture events */
SDL_DOLLARGESTURE   = 0x800,
SDL_DOLLARRECORD,
SDL_MULTIGESTURE,

We need some for mobile devices (touches) and others should be offered as part of IndieLib handling events for user

rev. 583 fixes SDL_MOUSEWHEEL

SDL window creation is not failure proof, also bpp is hardcoded after SDL 2.0 switch

Some grid lines are discarded and not drawn when zooming in, even if the lines are inside the viewport.

See line 141 in RenderObject2dDirectX.

This already done by DartHMike...

expand the xml definition to include image sheets.

read more about in this thread :

http://www.indielib.com/forum/viewtopic.php?f=1&t=352&start=105

Tinting and fade to color with a texture attached does not work for OpenGL

This is already done by DartHMike a long time ago.

Our Doxygen documentation should be up to date, - this requires that at least all public methods is documented and formatted according to our adopted code standard.

After library change grayscale images are not correctly loaded using freeImage. Need to verify/reimplement/fix:

• Load grayscale image, convert to another type
• Load rgb image, convert to another type
• Load grayscale image, transform it via any IND_Image methods.

When resetting window resolution in windowed mode, the call to SDL_SetWindowDisplayMode does not do anything. If we want to support resolution resetting on windowed mode without destroying the window this method in SDL 2.0 should offer params resetting.

Deleting window causes, for DirectX and OpenGL contexts/devices to be invalid, thus loosing all loaded objects (textures, buffer objects) on the renderer. User should then reload all assets, which complicates all engine logic.

Original non-crossplatform code used SDL 1.2, and called, without destroying the window, SDL_SetVideoMode(..), thus resetting window resolution correctly without destroying the video device/context.

Speed should be independent of framerate

For DirectX runs very fast.

For OpenGL speed is different (shouldn't be)

Need to modify the settings so we don't modify sources every time we switch between directx and opengl (and other renderers) in the future.

Already done by DarthMike...

Already done by DarthMike...

We should tolerate no warnings in the project. As far as OpenGL features are ported, we should remove all warnings.

Regarding linux, - At present time, these 4 are the only warnings that are left:

../common/dependencies/TmxParser/TmxMap.cpp: In member function 'void Tmx::Map::ParseFile(const string&)':
../common/dependencies/TmxParser/TmxMap.cpp:137:37: warning: ignoring return value of 'size_t fread(void_, size_t, size_t, FILE_)', declared with attribute warn_unused_result [-Wunused-result]

../common/dependencies/FreeImage/Source/ZLib/gzwrite.c: In function 'gz_comp':
../common/dependencies/FreeImage/Source/ZLib/gzwrite.c:93:9: warning: implicit declaration of function 'write' [-Wimplicit-function-declaration]

../common/dependencies/FreeImage/Source/ZLib/gzwrite.c: In function 'gzclose_w':
../common/dependencies/FreeImage/Source/ZLib/gzwrite.c:567:5: warning: implicit declaration of function 'close' [-Wimplicit-function-declaration]

../common/dependencies/FreeImage/Source/ZLib/gzlib.c: In function 'gz_open':
../common/dependencies/FreeImage/Source/ZLib/gzlib.c:213:9: warning: implicit declaration of function 'lseek' [-Wimplicit-function-declaration]

In linux : found these new ones:

../common/src/IND_AnimationManager.cpp: In member function 'bool IND_AnimationManager::addToSurface(IND_Animation_, char_, IND_Type, IND_Quality)':
../common/src/IND_AnimationManager.cpp:117:55: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
../common/src/IND_AnimationManager.cpp: In member function 'bool IND_AnimationManager::addToSurface(IND_Animation_, char_, IND_Type, IND_Quality, BYTE, BYTE, BYTE)':
../common/src/IND_AnimationManager.cpp:164:55: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
../common/src/IND_AnimationManager.cpp: In member function 'bool IND_AnimationManager::addToSurface(IND_Animation_, char_, int, IND_Type, IND_Quality)':
../common/src/IND_AnimationManager.cpp:203:55: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
../common/src/IND_AnimationManager.cpp: In member function 'bool IND_AnimationManager::addToSurface(IND_Animation_, char_, int, IND_Type, IND_Quality, BYTE, BYTE, BYTE)':
../common/src/IND_AnimationManager.cpp:246:55: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

This is already done by DarthMike...