danielstjules / geoip-ultralight Goto Github PK

As the title said, this is unmaintained, careful when integrating in your projects. To this day I see thousands of downloads per week. Also this includes MaxMind's data, which it shouldn't, in theory, due to licensing.

The update script doesn't work anymore and points to a non-existing host.

This is a message for anybody coming here and rightfully checking issues before choosing this seemingly popular library for his own project. Don't use this, data is very likely misleading due to age.

Cheers

geoip-ultralight uses [email protected], which in turn uses [email protected]. Recently there was vulnerability reported on nsp site.

https://nodesecurity.io/advisories/118

Can you please upgrade your dependency of [email protected].

Thanks.

When trying to update the country databases, sometimes the update script exits early without any error being reported:

$ npm run-script updatedb

> [email protected] updatedb /Users/srussell/Documents/work/git/data-collector/node_modules/geoip-ultralight
> node scripts/updatedb.js

Retrieving GeoIPCountryCSV.zip ... DONE
Extracting GeoIPCountryCSV.zip ...

It seems like the file was unzipped properly, since it matches the size of the file when the script does work correctly. It's just that the post-processing of that file doesn't happen and the IPv6 data isn't processed at all.

This happens on two different Mac OS X 10.11 machines, one running node 6.4.0, the other running 4.4.6.

Perhaps problems on other platforms also, not tested. Quick fix for anyone interested:
In fsWatcher.js find this line:
var filePath = path.join(directory, changedFile);
change to:
var filePath = path.join(directory, changedFile || 'no__file_passed__with_event');

Would it be possible to relax or bump rimraf and unzip dependencies?

npm WARN deprecated [email protected]: graceful-fs v3.0.0 and before will fail on node releases >= v7.0. Please update to graceful-fs@^4.0.0 as soon as possible. Use 'npm ls graceful-fs' to find it in the tree.

├─┬ [email protected]
│ ├─┬ [email protected]
│ │ └── [email protected] 
│ └─┬ [email protected]
│   └─┬ [email protected]
│     └── [email protected]  

Perhaps one could use the caret(^) instead of the tilde(~) in package.json for those two?

Thanks.

Just to say this comes up with
deprecated [email protected]: please upgrade to graceful-fs 4 for compatibility with current and future versions of Node.js
npm WARN deprecated [email protected]: please upgrade to graceful-fs 4 for compatibility with current and future versions of Node.js

Could you please update the unzip version to address this vulnerability? https://www.npmjs.com/advisories/886

Thanks for this package!

Sorry posted it on wrong repo...

Current version uses [email protected] which relies on a vulnerable version of fstream.

Details of the vulnerability (CVSS 7.3) are here:
https://app.snyk.io/vuln/SNYK-JS-FSTREAM-174725