Coder Social home page Coder Social logo

each's People

Contributors

dalu93 avatar sjoness avatar stupergenius avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

each's Issues

Make the `perform` closure return type more readable

Actually the return type is Bool

timer.perform {
    // return `true` if you want to stop the timer, otherwise `false` to continue
}

In an implemented way where we want to stop the timer after doing something(), the code below isn't readable by other developers

timer.perform {
    self.something()
    return true    // what does true mean? To continue it or to stop it?
}

A better way could be to declare an enum NextStep (as mentioned by @DeveloperPans) which encapsulates better the return type's meaning

enum NextStep {

    case stop
    case `continue`
}

Which has a fileprivate extension that converts the enum to a Bool for the perform closure.
The final result for the user will be

timer.perform {
    self.something()
    return .stop/.continue
}

pod install error

My 'Podfile':

source 'https://github.com/CocoaPods/Specs.git'
platform :ios, '8.0'
target 'XXX' do
  use_frameworks!
  pod 'Each', '~> 1.2'
end

And, pod install
the error is

[!] Unable to satisfy the following requirements:

- `Each (~> 1.2)` required by `Podfile`

None of your spec sources contain a spec satisfying the dependency: `Each (~> 1.2)`.

You have either:
 * out-of-date source repos which you can update with `pod repo update`.
 * mistyped the name or version.
 * not added the source repo that hosts the Podspec to your Podfile.

Note: as of CocoaPods 1.0, `pod repo update` does not happen on `pod install` by default.

but, if I delete pod 'Each', '~> 1.2'
the other pods is available

Add `Disposable` concept

To workaround the memory leak issue, an another idea could be to implement the famous pattern of Disposable and Disposer

// MARK: - Disposable declaration
public protocol Disposable {
    func dispose()
}

// MARK: - Disposable
extension Each: Disposable {
    public func dispose() {
        stop()
    }
}

// MARK: - Disposer declaration
public protocol Disposer {
    func add(_ disposable: Disposable)
    func dispose()
}

Memory Leaks

RunLoop retain Each's _timer property cause memory Leaks, Although _timer be marked as weak.

RunLoop -> Timer -> Each

Timer stops during scrolling

If the interface contains any scrollable item (table view, collection view, etc), then timer stops firing events while user scrolls the content.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.