cyanilux / shadergraphvariables Goto Github PK

Hi Cyanilux, I encountered an error, I migrated the project shader (and the unity version was updated), all Variable nodes went wrong, and the following error was reported.
I had to delete all Variable nodes.

Great package! Very helpful.

It would be great to be able to choose type explicitely. Float, Vector2, Vector3 etc. This could be housed in the graph inspector panel, under the node settings tab. When you select a Register Variable node, you'd see and set its type there.

Thank you!

Hey there!

I'm getting some editor stalls after upgrading a project from Unity 2021 LTS to the (newly released) Unity 2022 LTS.

It seems to occur within the editor update / 'CheckforGraphs' method when the Shadergraph window is refocused.

I enabled the debug messages in the code to see what's going on during the stall to see if I could find a fix to no avail —it reads the editor window as switched, clears the variable dictionary, registers each one back, and then handles the linking. This seems like what it should normally be doing, yea? It seems to be wildin' with GC allocations for a single frame when editor functionality returns.

Profiler screenshot, if it's of any help!

Currently Using:

• Unity 2022.3.1f1 LTS
• Shadergraph 14.0.8
• Shader Graph Variables 1.0.1

P.S. This is an invaluable QoL utility for Shadergraph so thanks for making it 🌞

Just using this issue to upload images/gifs to avoid them needing to be in the repo itself~

Turns out it was the extra feature with the very unique shortcuts S 1 2 3 4 5 6 7 8 9 that, when pressed, made the editor load a font, which freezes the editor at runtime for half a second.

The major issue with that is that it has an effect at runtime even without any shader graph tab open, resource loading is obsolete since a while already, there is no indication that a custom piece of code is doing something to return immediately (no shader graph open), and the shortcuts are way, WAY, too common.

I write this there to save some time to anyone wondering why the letter "S" Unity?? Why are you trying to access files??

The funniest thing is that I found out that this piece of code was even there because I mistakenly selected a Terrain at runtime while in scene view and Unity warned me that 2 editor code were using the letter "S" as shortcuts and that they would conflict. I almost dismissed it when it hit me like a heavy rock in the face.

我是2020.3.47f1c1，ShaderGraph10.10.1，导入后报错

Packages\ShaderGraphVariables-main\Editor\SGVariables.cs(411,24): error CS0246: The type or namespace name 'DropdownField' could not be found (are you missing a using directive or an assembly reference?)

这Unity的版本没有DropdownField

Opening the shader, or using undo, will take a long time at this step