coatue-oss / ngcomponent Goto Github PK

Version 5.5.0 of tslint just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As tslint is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

Version 1.6.22 of @types/angular just got published.

This version is covered by your current version range and after updating it in your project the build failed.

@types/angular is a direct dependency of this project this is very likely breaking your project right now. If other packages depend on you it’s very likely also breaking them.
I recommend you give this issue a very high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

https://github.com/coatue-oss/ngcomponent/blob/master/index.ts#L1, while tidier than individually importing each routine, results in a whopper of an import, and pollutes window._, particularly bad for us since we're using underscore.

Hi,

Per your existing Circle build, the current published build is broken in tsc 2.5.3. (via https://circleci.com/gh/coatue-oss/ngcomponent/217):

index.ts(24,52): error TS2345: Argument of type '"currentValue"' is not assignable to parameter of type 'ObjectIterator<{}, Props>'.

I might be able to find some time to work on this this weekend if you don't have time to address this right now.

Thanks,

Brekk

Same thing here now (with ngimport 0.7.2)

> [email protected] pretest /home/tlv/dev/ngcomponent
> npm run build


> [email protected] build /home/tlv/dev/ngcomponent
> npm run clean && tsc -d -m es2015 && mv ./index.js ./index.es2015.js && tsc -m commonjs -t es5


> [email protected] clean /home/tlv/dev/ngcomponent
> rm -f index.d.ts

test.ts(326,13): error TS2554: Expected 1 arguments, but got 0.

Version 2.4.1 of typescript just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As typescript is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

But passes great locally

Expected: It should be called with (nextProps, nextState), and inside the method this.props and this.state should refer to the current props and state.

Actual: It is called with (nextProps, nextProps), and inside the method this.props refers to the same nextProps.

Version 1.6.5 of angular just got published.

This version is covered by your current version range and after updating it in your project the build failed.

angular is a direct dependency of this project this is very likely breaking your project right now. If other packages depend on you it’s very likely also breaking them.
I recommend you give this issue a very high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

We should add a $watch on this.state, and fire render() when it changes to be more in line with React's API.

Version 2.5.54 of @types/jasmine just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As @types/jasmine is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

#19 (comment)

it installs xvfb every time which takes a decent chunk of time

also use circle features like caching to speed up installs

See https://facebook.github.io/react/docs/react-component.html#defaultprops

Version 0.7.2 of ngimport just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As ngimport is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

requires factoring code out of $onChanges

notes:

• ensure componentWillReceiveProps event is not triggered on setState
• componentWillReceiveProps can call setState
• nextState shouldn't be merged into this.state until after shouldComponentUpdate is called (that is, when implementing setState, dont just assign into this.state... store that state in temporary variable and trigger cycle without componentWillReceiveProps)
• make this.state public

As far as I understood, when no $onChanges function is invoked (i.e. when the component has no props), no this.render() is run

What if add this.render inside the $postLink?

So tests that fail are using the DOM with renderComponent.

Since the other tests pass, presumably karma is able to start with a browser, so unsure as to why tests are failing. Any ideas?

Should be given nextProps, not newProps

https://facebook.github.io/react/docs/react-component.html#componentwillreceiveprops