Error: Cannot find module 'lodash' from 'ngcomponent' about ngcomponent

[bcherny]

Did you run npm install?

[tlvince]

This appears to be because lodash is being loaded via named imports on from 'lodash', whereas the package depends on the per-method packages.

#20

[tlvince]

Fixing the imports (import some from 'lodash.some' etc.) throws index.ts(1,8): error TS1192: Module '"/ngcomponent/node_modules/@types/lodash.some/index"' has no default export.. Any ideas?

[bcherny]

How do I reproduce the issue you're seeing? If this is master, it works fine on my machine and on CI - https://circleci.com/gh/coatue-oss/ngcomponent/166

[tlvince]

The issue is lodash is pulled in by another devDependency. Can you try rm -rf node_modules/lodash or try this package-lock.json?

NB, I triggered this by using ngcomponent as a dependency in another package and running npm i --production.

[meganwalker-ibm]

We've hit a similar issue that we think is caused by this.

We have lodash included via another devDependency; and because it's using the named imports with from lodash when webpacking it bundles the entirety of lodash in our bundle, inflating our production bundle size significantly.

I suspect that should the linked PR be merged (or an alternative used that imports only the specific bits) this would be resolved for us.

[bcherny]

Before we merge anything, I'd like to make the sure diagnosis is correct. I am not able to reproduce this issue on my end. @meganwalker-ibm @tlvince Can one of you post a self-container repro case.

[bcherny]

Closing for inactivity. @tlvince @meganwalker-ibm feel free to reopen if this is still an issue and you can provide specific steps so that I can reproduce this issue.