civclassic / finale Goto Github PK

See video

As of the last week this is common with mobs. Players may or may not be affected.

Including diagonals

Sometimes there's weird blinking client side due to applying it repeatedly. Might need to improve some of the logic if its not being constantly reapplied.

[01:37:16] [Paper Watchdog Thread/ERROR]: --- DO NOT REPORT THIS TO PAPER - THIS IS NOT A BUG OR A CRASH - git-Tuinity-"ac3aee1" (MC: 1.16.5) ---
[01:37:16] [Paper Watchdog Thread/ERROR]: The server has not responded for 7 seconds! Creating thread dump
[01:37:16] [Paper Watchdog Thread/ERROR]: ------------------------------
[01:37:16] [Paper Watchdog Thread/ERROR]: Server thread dump (Look for plugins here before reporting to Paper!):
[01:37:16] [Paper Watchdog Thread/ERROR]: ------------------------------
[01:37:16] [Paper Watchdog Thread/ERROR]: Current Thread: Server thread
[01:37:16] [Paper Watchdog Thread/ERROR]: PID: 34 | Suspended: false | Native: false | State: RUNNABLE
[01:37:16] [Paper Watchdog Thread/ERROR]: Stack:
[01:37:16] [Paper Watchdog Thread/ERROR]: app//net.minecraft.server.v1_16_R3.ScoreboardServer.sendAll(ScoreboardServer.java:253)
[01:37:16] [Paper Watchdog Thread/ERROR]: app//net.minecraft.server.v1_16_R3.ScoreboardServer.handlePlayerRemoved(ScoreboardServer.java:44)
[01:37:16] [Paper Watchdog Thread/ERROR]: app//net.minecraft.server.v1_16_R3.Scoreboard.resetPlayerScores(SourceFile:131)
[01:37:16] [Paper Watchdog Thread/ERROR]: app//org.bukkit.craftbukkit.v1_16_R3.scoreboard.CraftScoreboard.resetScores(CraftScoreboard.java:159)
[01:37:16] [Paper Watchdog Thread/ERROR]: vg.civcraft.mc.civmodcore.scoreboard.side.CivScoreBoard.internalUpdate(CivScoreBoard.java:75)
[01:37:16] [Paper Watchdog Thread/ERROR]: vg.civcraft.mc.civmodcore.scoreboard.side.CivScoreBoard.set(CivScoreBoard.java:69)
[01:37:16] [Paper Watchdog Thread/ERROR]: com.github.maxopoly.finale.overlay.ScoreboardHUD.updateDurabilities(ScoreboardHUD.java:211)
[01:37:16] [Paper Watchdog Thread/ERROR]: com.github.maxopoly.finale.overlay.ScoreboardHUD.lambda$new$0(ScoreboardHUD.java:48)
[01:37:16] [Paper Watchdog Thread/ERROR]: com.github.maxopoly.finale.overlay.ScoreboardHUD$$Lambda$5588/0x00007f04e7a1f0b0.run(Unknown Source)
[01:37:16] [Paper Watchdog Thread/ERROR]: app//org.bukkit.craftbukkit.v1_16_R3.scheduler.CraftTask.run(CraftTask.java:100)
[01:37:16] [Paper Watchdog Thread/ERROR]: app//org.bukkit.craftbukkit.v1_16_R3.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:468)
[01:37:16] [Paper Watchdog Thread/ERROR]: app//net.minecraft.server.v1_16_R3.MinecraftServer.b(MinecraftServer.java:1489)
[01:37:16] [Paper Watchdog Thread/ERROR]: app//net.minecraft.server.v1_16_R3.DedicatedServer.b(DedicatedServer.java:437)
[01:37:16] [Paper Watchdog Thread/ERROR]: app//net.minecraft.server.v1_16_R3.MinecraftServer.a(MinecraftServer.java:1402)
[01:37:16] [Paper Watchdog Thread/ERROR]: app//net.minecraft.server.v1_16_R3.MinecraftServer.w(MinecraftServer.java:1134)
[01:37:16] [Paper Watchdog Thread/ERROR]: app//net.minecraft.server.v1_16_R3.MinecraftServer.lambda$a$0(MinecraftServer.java:292)
[01:37:16] [Paper Watchdog Thread/ERROR]: app//net.minecraft.server.v1_16_R3.MinecraftServer$$Lambda$3160/0x00007f065ecfd040.run(Unknown Source)
[01:37:16] [Paper Watchdog Thread/ERROR]: [email protected]/java.lang.Thread.run(Thread.java:829)
[01:37:16] [Paper Watchdog Thread/ERROR]: ------------------------------
[01:37:16] [Paper Watchdog Thread/ERROR]: --- DO NOT REPORT THIS TO PAPER - THIS IS NOT A BUG OR A CRASH ---
[01:37:16] [Paper Watchdog Thread/ERROR]: ------------------------------

[08:23:21 ERROR]: Nag author: 'Maxopoly' of 'Finale' about the following: This plugin is not properly shutting down its async tasks when it is being shut down. This task may throw errors during the final shutdown logs and might not complete before process dies.

The durability of every item of every player is being grabbed constantly, whether or not the player has their /config set to display durability. Scoreboard uses 1% of the server, and the vast majority of that is ScoreboardHUD.updateDurabilities(). Could be optimized by only updating durability if the player has it set to display in /config? Could also do it on a timer or something?

Previously that feature lived in Humbug (I think?). I think it's better suited here than in our own CTP fork, because we haven't been maintaining that at all.

Should be toggleable via config

Toggleable via /config, also add option to allow adjusting amount of decimals shown (>=0 and <= 5)

Running /ally Hjaltland (maybe come up with a better command name) will use ProtocolLib to turn the chest plate and pants of all players on the group into green dyed armor and all of those not on the group into red dyed armor for the player. Properly respect if players are not wearing those armor pieces at all and tie usage to a permission, because it's effectively a bypass on listing members or member checking someone. Properly reset armor if its turned off.

Functional gamma bright replacement

Triggers at way too low CPS, I can click a mob at like 3 CPS and easily get the 9 CPS cap to trigger repeatedly

@jayms

Remove the need for potion HUDs by displaying active potion information in the score board using our CMC API

Fire, cactus and similar will damage on every tick, need to implement custom invulnerability which separates damage from fire etc. from damage from other sources (getting hit, gravity etc.)

[13:46:55] [Protocol Worker #9 - Finale - [recv: BLOCK_DIG[class=PacketPlayInBlockDig, id=27], ARM_ANIMATION[class=PacketPlayInArmAnimation, id=44], USE_ENTITY[class=PacketPlayInUseEntity, id=14], send: ]/ERROR]: [Finale] Unhandled exception occured in onAsyncPacket$
java.lang.IllegalArgumentException: entityID cannot be negative
at org.apache.commons.lang.Validate.isTrue(Validate.java:136) ~[patched_1.16.4.jar:git-Paper-355]
at com.comphenix.protocol.injector.EntityUtilities.getEntityFromID(EntityUtilities.java:205) ~[?:?]
at com.comphenix.protocol.injector.PacketFilterManager.getEntityFromID(PacketFilterManager.java:851) ~[?:?]
at com.comphenix.protocol.wrappers.BukkitConverters$10.getSpecific(BukkitConverters.java:678) ~[?:?]
at com.comphenix.protocol.wrappers.BukkitConverters$10.getSpecific(BukkitConverters.java:663) ~[?:?]
at com.comphenix.protocol.reflect.StructureModifier.readInternal(StructureModifier.java:229) ~[?:?]
at com.comphenix.protocol.reflect.StructureModifier.read(StructureModifier.java:197) ~[?:?]
at com.github.maxopoly.finale.combat.AsyncPacketHandler.onPacketReceiving(AsyncPacketHandler.java:66) ~[?:?]
at com.comphenix.protocol.async.AsyncListenerHandler.processPacket(AsyncListenerHandler.java:642) ~[?:?]
at com.comphenix.protocol.async.AsyncListenerHandler.listenerLoop(AsyncListenerHandler.java:596) ~[?:?]
at com.comphenix.protocol.async.AsyncListenerHandler.access$200(AsyncListenerHandler.java:48) ~[?:?]
at com.comphenix.protocol.async.AsyncListenerHandler$2.run(AsyncListenerHandler.java:229) ~[?:?]
at com.comphenix.protocol.async.AsyncListenerHandler$3.run(AsyncListenerHandler.java:300) ~[?:?]
at org.bukkit.craftbukkit.v1_16_R3.scheduler.CraftTask.run(CraftTask.java:99) ~[patched_1.16.4.jar:git-Paper-355]
at org.bukkit.craftbukkit.v1_16_R3.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:54) ~[patched_1.16.4.jar:git-Paper-355]
at com.destroystokyo.paper.ServerSchedulerReportingWrapper.run(ServerSchedulerReportingWrapper.java:22) ~[patched_1.16.4.jar:git-Paper-355]
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) [?:?]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) [?:?]
at java.lang.Thread.run(Thread.java:834) [?:?]

Remove the need for armor HUDs by displaying armor durability in the score board using our CMC API