chriseidhof / github-issues

Functional View Controllers

This is all very much work in progress, and mainly done to show what is possible in Swift.

The current interface looks a lot like flatMap (in the code, it's the >>> operator).

A video explaining how to use this was recorded at the Swift Summit in London: https://www.youtube.com/watch?v=sXHJ-CeN0Us

github-issues's Issues

Proposal for API design

First of all, thanks for your work, it's very promising !

I thought about this earlier this week and I came up with an API I'd like to see in the future, so, seeing your enthusiasm on the subject, here it is.

let flow = root(screen1)
>>> push(screen2) // here it would be great to model a choice, using an other adapter function ?
>>> presentModally(screen3)
>>> dismiss()
>>> pushAndReplaceAll(screen4)
>>> pushAndReplaceLast(screen5)

The idea is to asbtract the act of pushing, presenting, dismissing, etc. into functions. Navigation Controller could be one provider of these functions. The functions root, push, etc. acts as adapters like what you see in map or filter.

What do you think ?

_Nice to have_ support for 2FA

I just downloaded the code and tried running it; after setting up my token the app loads a view controller asking for username & password; I'm assuming those are credentials(?) but since I have 2FA enabled it keeps failing 😢

Thanks Chris!

This looks really cool! I hope I can play with it soon. I watched your video from the swift summit. I just wanted to say thanks for working to apply some of the cool functional parts of swift with practical UI implementation.

-Jeff

build errors with Xcode 7.2.1

Hoi Chris - just downloaded your project and I'm getting a bunch of build errors with Xcode 7.2.1. For a couple, Xcode gave a solution, but for the others I have no idea how to fix it. If you have a chance, would you mind looking into this?

github-issues-master/CoreDataStack.swift:107:67: Extra argument 'error' in call
github-issues-master/CoreDataStack.swift:140:51: Nil is not compatible with expected argument type '()'
github-issues-master/CoreDataStack.swift:175:46: Extra argument 'error' in call
github-issues-master/CoreDataStack.swift:140:13: Call can throw, but it is not marked with 'try' and the error is not handled
github-issues-master/GithubIssues/LoginViewController.swift:16:13: Variable 'vc' was never mutated; consider changing to 'let' constant
github-issues-master/GithubIssues/IssueEditViewController.swift:19:13: Variable 'vc' was never mutated; consider changing to 'let' constant
github-issues-master/GithubIssues/GithubAPI.swift:47:16: Immutable value 'dict' was never used; consider replacing with '_' or removing it
github-issues-master/GithubIssues/GithubAPI.swift:73:28: Missing argument labels 'method:requestParameters:parse:' in call
github-issues-master/GithubIssues/GithubAPI.swift:87:28: Missing argument labels 'method:requestParameters:parse:' in call
github-issues-master/GithubIssues/GithubAPI.swift:105:28: Missing argument labels 'method:requestParameters:parse:' in call
github-issues-master/GithubIssues/GithubAPI.swift:149:24: Missing argument labels 'method:requestParameters:parse:' in call
github-issues-master/GithubIssues/GithubAPI.swift:160:24: Missing argument labels 'method:requestParameters:parse:' in call
github-issues-master/GithubIssues/GithubAPI.swift:165:13: Variable 'result' was never mutated; consider changing to 'let' constant
github-issues-master/GithubIssues/GithubAPI.swift:181:15: Missing argument labels 'baseURL:resource:failure:progress:completion:' in call FunctionalViewControllers Group
github-issues-master/FunctionalViewControllers/FunctionalViewControllers/TableView.swift:51:95: Closure parameter prior to parameters with default arguments will not be treated as a trailing closure
github-issues-master/FunctionalViewControllers/FunctionalViewControllers/APIClient.swift:71:39: Immutable value 'statusCode' was never used; consider replacing with '_' or removing it
github-issues-master/FunctionalViewControllers/FunctionalViewControllers/APIClient.swift:72:34: Immutable value 'errors' was never used; consider replacing with '_' or removing it

Question regarding Testing

Are you thinking about using a framework like Quick, or you are happy with XCTest?