_Nice to have_ support for 2FA about github-issues

[chriseidhof]

Ah yeah! Well, this view controller doesn't do much, you need to set the github token... just add it in Credentials.swift. Would be great to have 2FA support, would you mind making a pull request for that?

[esttorhe]

I would love to :)

Actually I finished watching your presentation at Swift Summit not 1 hour ago and I thought about submitting a PR for this.

Will try to do so before EOD today or during the weekend 👊

[neilpa]

FYI - you can create personal access token and use that as your password. You don't actually need to support 2FA directly.

[esttorhe]

@neilpa I have set the access token

after setting up my token the app loads a view controller

But I found out the issue; the code in master has this:

//let baseURL = NSURL(string: "https://api.github.com")!
let baseURL = NSURL(string: "http://localhost:4567")!

So it was trying to connect to a dev server; uncommenting the correct line makes it work as expected 🙇

---

Edit:
I'm going to leave this issue open because I'm planning on supporting 2FA anyways to learn more about this experiment of Functional View Controllers.

Feel free to 🚫 this if you want though

[chriseidhof]

Okay, I'm gonna close this, please open a PR once you start working on 2FA =)