brendanhay / terrafomo

Le Fromage de Terreur - Auto-generated Terraform DSL

Terrafomo

terrafomo's Issues

String escaping

Given something like this:

jobDefinition :: TF.State () "job-definition" s ()
jobDefinition = do
  TF.resource_
      $ AWS.newBatchJobDefinitionR
          (AWS.BatchJobDefinitionR
              { AWS.name = "todo"
              , AWS.type_ = "container"
              })
          & #container_properties .~ Just "\""

I get the output without any string escaping:

resource "aws_batch_job_definition" "r" {
  provider = "aws.1"
  container_properties = """
  name = "todo"
  type = "container"
}

Stylish-haskell

If you have a global config you are using, could you check it in here 😄

Dereference Expr of ARN as Expr of Text

A lot of AWS' responses give back the ARN type but a lot of AWS requests require Text. I have a cast at the moment, which works because it's just a newtype. Is there something existing I can do instead?

AWS.BatchComputeEnvironmentComputeResources
{ instance_role = dodgyCast (view #arn iamInstanceRole)
}

aws provider overlapping settings types

In the model there are two definitions: https://github.com/brendanhay/terrafomo/blob/master/terrafomo-gen/model/aws.json of attribute within the schemas list.

`aws_dynamodb_table`

``` "name": "aws_dynamodb_table", "schemas": [ { "name": "attribute", "type": "TypeSet", "conflictsWith": [], "optional": false, "required": true, "computed": false, "forceNew": false, "sensitive": false, "minItems": 0, "maxItems": 0, "resource": { "name": "attribute", "schemas": [ { "name": "name", "type": "TypeString", "conflictsWith": [], "optional": false, "required": true, "computed": false, "forceNew": false, "sensitive": false, "minItems": 0, "maxItems": 0 }, { "name": "type", "type": "TypeString", "conflictsWith": [], "optional": false, "required": true, "computed": false, "forceNew": false, "sensitive": false, "minItems": 0, "maxItems": 0 } ] } }, ```

`aws_lb_ssl_negotiation_policy`

``` "schemas": [ { "name": "attribute", "type": "TypeSet", "conflictsWith": [], "optional": true, "required": false, "computed": false, "forceNew": true, "sensitive": false, "minItems": 0, "maxItems": 0, "resource": { "name": "attribute", "schemas": [ { "name": "name", "type": "TypeString", "conflictsWith": [], "optional": false, "required": true, "computed": false, "forceNew": false, "sensitive": false, "minItems": 0, "maxItems": 0 }, { "name": "value", "type": "TypeString", "conflictsWith": [], "optional": false, "required": true, "computed": false, "forceNew": false, "sensitive": false, "minItems": 0, "maxItems": 0 } ] } }, ```

.

In the intermediate representation these have been combined into a single AttributeSettings with the union of the two above

`AttributeSetting'`

``` "con": { "smart": "newAttributeSetting", "name": "AttributeSetting'" }, "arguments": [ { "default": "_name", "computed": false, "required": true, "help": [], "forceNew": false, "encoder": "TF.assign \"name\" <$> TF.attribute", "name": "_name", "method": "name", "threaded": true, "conflicts": [], "type": "TF.Attr s P.Text", "class": "HasName", "validate": false, "optional": false, "original": "name" }, { "default": "_type'", "computed": false, "required": true, "help": [], "forceNew": false, "encoder": "TF.assign \"type\" <$> TF.attribute", "name": "_type'", "method": "type'", "threaded": true, "conflicts": [], "type": "TF.Attr s P.Text", "class": "HasType'", "validate": false, "optional": false, "original": "type" }, { "default": "_value", "computed": false, "required": true, "help": [], "forceNew": false, "encoder": "TF.assign \"value\" <$> TF.attribute", "name": "_value", "method": "value", "threaded": true, "conflicts": [], "type": "TF.Attr s P.Text", "class": "HasValue", "validate": false, "optional": false, "original": "value" } ], ```

.

Ill start having a look at this now, just documenting before I do

State of module support

Is there a way to explicitly import or provide native Terraform modules? If not, what are your thoughts on that?

Reference as a list

I need to reference a data source which has a list. When I have the following code:

AWS.BatchComputeEnvironmentComputeResources
{ subnets = view #ids subnets
}

I get:

subnets = "${data.aws_subnet_ids.d.ids}"

But Terraform actually needs weird syntax like:

subnets = [
  "${data.aws_subnet_ids.d.ids}",
]

Don't believe Terraform's documentation on how to reference a variable as a list. It's wrong hashicorp/terraform#13869

package.yaml missing for terrafomo-builtins

Perhaps it's auto-generated and you forgot to check it in?

(This project looks very promising. I hope it goes somewhere!)

Provisioners

Direct support for provisioners like local_exec would be quite useful. We're bolting this onto our stale fork at the moment.

Support null provider / null_resource

https://github.com/terraform-providers/terraform-provider-null

null_resource has been useful as a way to run once-only provisioners via local_exec (we don't do this very often but it has been necessary for bootstrapping EKS auth)

Have written some manual code for this but also seems like it might fit into terrafomo-builtins.

Would be happy to do this work, just unsure if you'd rather generate it or have it written by hand.