Coder Social home page Coder Social logo

gcl's Introduction

gcl's People

Contributors

bloomen avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

Forkers

gmh5225

gcl's Issues

Remove promise/future in lieu of a different approach

Apparently, using futures is not the most efficient approach so we should investigate whether we can have a dedicated scheduler which collects all tasks and then offloads them to workers. Each worker could have its own queue. Once a task's parents have all finished a task is marked as ready and given to any worker. The worker will assign the result once finished.

[suggest] Cache Entries are usually all-uppercased.

Suggestion

I noticed that the cache entries listed in CMakeLists.txt are all-lowercased.

gcl/CMakeLists.txt

Lines 4 to 7 in 541d398

option(gcl_build_tests "Build gcl tests." OFF)
option(gcl_enable_asan "Build gcl with address sanitizer." OFF)
option(gcl_enable_tsan "Build gcl with thread sanitizer." OFF)
option(gcl_enable_coverage "Build gcl with coverage reporting." OFF)

However according to my observation, they are usually all-uppercased. At least, letters except the package name should be all-uppercased. That is:

  • Scheme 1:

    • GCL_BUILD_TESTS
    • GCL_ENABLE_ASAN
    • GCL_ENABLE_TSAN
    • GCL_ENABLE_COVERAGE
  • Scheme 2:

    • gcl_BUILD_TESTS
    • gcl_ENABLE_ASAN
    • gcl_ENABLE_TSAN
    • gcl_ENABLE_COVERAGE

Versions

  • gcl: 1.1.0

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.