biscuitdevelopment / skyblockaddons Goto Github PK

The current mappings are stable_20 which were made for 1.8.8,
for 1.8.9 use stable_22

https://github.com/biscuut/SkyblockAddons/blob/9e7eefdde20751ff7fd008a403ca851d593d27ae/build.gradle#L44

Gif:

So for the roman numeral replacer that turns the roman numerals into numbers, some instances it doesn't work.
Like whenever you change your slot and the item name shows, the item name isn't in numbers its in roman numerals.
(Look at the item name above the health)

EDIT:
That's a pretty insignificant bug, but there is something about the Roman Numeral Replacer that is pretty bad.

Where it says "RARE SWORD" It replaced D with 500. And after turning off the feature, it turned back into the right words.
I'd suggest to only replace if its not the last line of lore, or only replace if there's a space before it. (Or remove D entirely, because almost no items have a level D)

Related commit

The "Avoid breaking sugar cane base" feature is pretty much mandatory for anyone with a sugarcane farm, unless they want to go through and put slabs everywhere to avoid falling in water.

Why was this feature disabled? And is it coming back? I can't farm sugarcanes anymore.

It's just annoying to trigger profile views by accident because someone's in front of you, disabling it each time is too tedious.

Edit: #93

In the Item Pickup Log there is no diffrence between the Clay block and the clay ball they get counted thowards the same item

And allow us to click/shift-click to craft them automatically? For example if you have a full inventory of cobblestone it'd show you the enchanted cobblestone recipe and you'd just shift-click it to craft all your cobblestone into the enchanted version. Something like the recipe book that was added in later versions.

https://github.com/biscuut/SkyblockAddons/blob/master/src/main/java/codes/biscuit/skyblockaddons/utils/Utils.java#L92
startsWith("SKYBLOCK")

but
(Chinese translation)

i think there should be a option to choose what to detect.

After the new update, the bones aren't being indicated properly and the "Hide bones" feature isn't working.
This is most likely due to how they fixed the bones becoming an Aiming target, so something about it must have changed.

In this picture I have the "Hide bones" feature enabled, and the indicator is supposed to be above my hotbar. As you can see, you can see the bones and there isn't any indicator.
As a programmer, I'd recommend looking at https://github.com/biscuut/SkyblockAddons/blob/master/src/main/java/codes/biscuit/skyblockaddons/mixins/MixinRenderManager.java#L27-L28
Possibly it's no longer riding a zombie or something? Looking at entity counts, it appears that it is indeed still riding something, but since it's invisible, I don't know exactly. what it is, or if it's changed.

I figured I'd open an issue since I see you're about to release a new version.

Items in chests should normally have a white background when selected, but it's missing.
When switched to the old version of sba, the glitch is resolved. So it's a bug with the new version of sba.

The game instantly crashes on launch
latest.log

When using a Wand Of Healing it adds an extra 2 digits to the end of your health and makes the health bar not show health at all until the timer for the healing wand is done.

This is what it looks like on your health bar

and this is what it looks like on the normal one

from what it looks like you're just getting the numbers in the bar so it also includes the 20 thats there and makes the health bar glitch out and things it has 2 more digits that it should have.

Here is a more clear demonstration of the bug: http://youtube.com/watch?v=G5uqjV_4Gtg
As you can see the mod randomly hides players and NPCs from the Village when approached close the NPCs and players are rendered again. This is irrespective of having the Hide Players near Auction House option on or off. The bug is only seen in the Village, all other areas other than Village, the NPCs and villagers are perfectly rendered. I have attached a part where I have removed the mod and the bug is no longer seen hence it can be confirmed that SkyblockAddons is causing the bug. The Hide Players near Auction House is only supposed to be for players who are in 4 block radius of the Auction Master, not the entire world. You can even see that the players in the default spawn position are not being rendered.

It would be really cool if you could add some sort of timer in the corner which tells you how many seconds are left till you can use your grappling hook again.

Whenever you put on armor, it says -1 armor name, and when you take it off, it says +1 armor name.
Maybe include the armor as part of the inventory whenever checking for item

Nvm about this suggestion below (but I'll leave it anyways):
Also, as a (possible) suggestion, maybe make the log include coins, as the system that hypixel has for telling whenever you get coins is very bad.

As you might know, in Patch 0.7.3, End Portal Frame Zealots were re-introduced, but with different mechanics. Now, whenever killing a Zealot, there is a small chance of spawning an End Portal Frame Zealot, which is accompanied by a sound and a chat message. Perhaps you could add something similar to Ender Chest Highlighting, but with Portal frames? Perhaps you could use the color #ff00ff, which is also neon-bright, but easily distinguished from neon green. Additionally, since there is a chat message, perhaps you could add a warning when you spawn one, that appears on screen like the Summoning Eye alert.

When you craft a medium backpack with an already opened small backpack the medium backpack hover GUI will show 1 row until opened. As shown in the screenshot below.

As title said, When locked some item and shift+click+drag. Items comes out from locked slot.

I have played SBA v 1.3.4 for a bit, and I love it. All the GUI enhancements and other features really add to the Skyblock experience. However, I can see an area it can be improved : showing item collection bar status.
You could add a setting to SBA that could show item collections. The amount and type of collections shown could be up to the player, and the location on the screen can be moved in a similar manner to the other GUI enhancements. The bars could be color coded in ways determined by the user.

It is the breaking part that makes it crash, not the picking up. Telekinesis or not doesn't seem to matter. Killing mobs or breaking glowstone/netherrack doesn't make it crash. I wasn't able to catch the exception with Intellij for some reason, it's on this line. It seems that mc.getRenderItem() produces a null result that causes the NullPointerException. I don't understand why it only happens with netherwart.

I'm attaching the log if you think it may help.
crash-2019-10-28_23.27.11-client.txt

Here c:
Should automatically build on every new commit. I will monitor it for the next couple days to make sure it's working fine.

It's happen in all Minecraft GUI Scale

https://imgur.com/a/LzYWqjg

I assume this is the corporate:
https://github.com/biscuut/SkyblockAddons/blob/9fc36369ca79fac98d5e8b9521e528ef370be853/src/main/java/codes/biscuit/skyblockaddons/utils/RomanNumeralParser.java#L19

\w+ matches with the rest of the string no matter what. So "Xpro_gamerX" will be a complete match every single time.
\w will only match "Xp" and "X" and removing it completely will only match the 2 "X"s

Here is a potential fix (Not tested in game): (?=[MDCLXVI])M*(C[MD]|D?C{0,3})(X[CL]|L?X{0,3})(I[XV]|V?I{0,3})(?!\\w)
It does the same as your regex except any matches that are in a word (alphanumeric + underscores) will be rejected.
ie: "Sharpness V," the "V" matches
The problem is that with the example "Xpro_gamerX" the last X is captured.
Another potential fix (again, untested): (?:\\s)(?=[MDCLXVI])M*(C[MD]|D?C{0,3})(X[CL]|L?X{0,3})(I[XV]|V?I{0,3})(?!\\w)
In this case "Xpro_gamerX" has no match but any roman numeral would need to be preceded by whitespace. (It's in a non-capturing group though, not sure how java deals with that)
ie: "Sharpness V" the "V" matches but may include whitespace depending on java's implementation of regex

Thank you for your time

Log
https://pastebin.com/xsnsCUFA

Hi,
I caught this:
I'm not sure how it happens but it seems pretty consistent.

Steps to reproduce:

1. In the village click on a merchant
2. exit the menu

And looking at it again I think I might have an explanation for it…
The name of all the items in the player's inventory is changed to include the number of each items inlined with the name. "Lore" is also added on some items for the price.
ie: a single potato becomes "potato x1"

Given that it's just a quirk with how skyblock's merchant system works I propose marking this as "won't fix", it's a harmless "bug" and I'm not sure it's worth the added code complexity.

This is related to the feature that was just added (#153).

For some reason, when compiling @comniemeer's version it worked fine. Compiling the version that was merged (#145) results in a 15 seconds cooldown instead of 1.5 seconds.

An indicator like Magma Boss Warning just for the Brood Mother

I have discovered that after I get the absorption effect, the healthbar will show a value which really seems to be false since absorption shouldn't give me that much hearts. I verified it by looking on my health without the mod.
Mod with absorption:

Vanilla with absorption:

All other items with level V show as 5

When I developing this feature, it was working but now it doesn't wok anymore, I will try to fix this feature.

Sometimes, after switching slots, you're able to drop items from a locked slot.
In order to replicate:

1. Disable hypixel's skyblock item drop confirmation
2. Keep switching between a locked and an unlocked slot while you spam the drop key
3. Drop your runaan's bow which is worth around 1.7mil
4. Cry on a corner

https://youtu.be/-H_qSEuIu0g (wasn't able to send the video without uploading it to youtube, sorry!)

for example crafting regular fermented spider eyes with enchanted spider eyes, droppers with enchanted cobble, regular redstone blocks with enchanted redstone, etc

Can you make a setting where you can type in items that you don't want to pick up which could be helpful while grinding

After clicking on the cogwheel to enter the settings of a menu item, the main menu items will not be translated.

I'm trying to add this feature as pull request. so I need to overwrite renderTooltips method on GuiScreen class.
Is there any way to use Overwrite annotation on skyblockaddons?

Without changing the scale of GUI, I made a Mod that makes smaller scale of tooltips like enchantments only for items sold at auction!

🔗 https://twitter.com/GamingTomo/status/1166270677285888001

If "Make Enderchests in End Green feature turned on, it also makes Skyblock menu's Enderchest green.

So We can remove the "Hide the Tool Durability" Feature.

🔗 https://hypixel.net/threads/skyblock-patch-0-7-1.2280493/

I finded a another word for french but I post here in case of other problem for a another language file.

(Showing the sentence "Enchantements à correspond" instead of "Enchantements à correspondre". So the sentence is splitted after 27 characters.)

Recently they fixed an issue where the message was not sent when a mob dropped a rare item. Therefore, it is now possible to more reliably determine whether or not you have obtained Summoning Eye with ClientChatReceivedEvent.

https://github.com/biscuut/SkyblockAddons/blob/3a4b2876e31ed62544015f26bb65e92805e379eb/src/main/java/codes/biscuit/skyblockaddons/utils/InventoryUtils.java#L132

It would be really nice if we can lock some certain slots in the Hotbar so that we can never accidentally sell/drop our precious items by mistake.
I accidentally threw my runaans bow when sorting out my inventory and some random guy picked it up and refused to give back. Now I have a 50mil Midas and I'm very afraid to lose it. Adding this feature will help a lot. Thanks!

SkyblockAddons is supposed to prevent the user from dropping rare items and tools from their hotbar. I tested this and was unable to drop my unenchanted Rapid Wither Bow and my Spicy Rogue Sword enchanted with Telekinesis I, but I was able to drop my Spicy Silver Fang enchanted with Telekinesis I.

Look here: MixinPlayerControllerMP.java Line 52
It's just plain wrong. Here is the working version: MixinPlayerControllerMP.java Line 39 Commit: 027d822

Your implementation doesn't work with a stone hoe such as the rookie hoe.
Either that or the message is wrong. ie: you can't break the bottom block with bare hands. Since you check if (heldItem == null || /*hoes, sugarcane*/)
@biscuut
Thank you for your time

I think a feature that show your progress with each piece of revenant armour can be great.

Its possible by reading lore

There's a lot of chinese players enjoying skyblock, I can see them loving this mod, by any chance if this mod has a lang file? I can provide a localized file for simplified chinese.

(Please mark as Enhancement, this isn't an issue)
So I was looking on the forums and saw how there was Night Vision charm. However, people complained that it was glitched whenever there they are on an island with a day saver. (I myself don't have the talisman, so idk if its true, but I could see it being possible)

So I figured, hey, maybe you could add an option to simply make the Night Vision either not blink, or do nothing. If it were to not blink, they could be considered a minor unfair advantage, but if it were to be disabled, it wouldn't shouldn't be considered an advantage.
Of course, have it default set to disabled, just so people don't complain about it disabling night vision out of the box.

I have only seen an different person's opinion about the effect, so I don't know if its true, so I'd recommend to do a bit of research and find out what happens and figure out how to help without giving an unfair advantage.