Coder Social home page Coder Social logo

Comments (4)

DidiSkywalker avatar DidiSkywalker commented on June 18, 2024

Coins are displayed in the scoreboard next to your purse now right? I think that's pretty good and would only clutter the pickup log.
But armor slots should probably be included, yea.

from skyblockaddons.

MCGamer00000 avatar MCGamer00000 commented on June 18, 2024

Yes, it is included now, but it is much like the action bar system, sometimes it increases more than the s coreboard says it increases. Like Scavenger and telekinesis set the scoreboard at the same time, and only one shows.
Anyway, your right that it would clutter. Let's just forget about the suggestion.
The point of this issue is to include the armor slots.

from skyblockaddons.

ViralTaco avatar ViralTaco commented on June 18, 2024

Also, as a (possible) suggestion, maybe make the log include coins, as the system that hypixel has for telling whenever you get coins is very bad.

That's actually due to how minecraft was made, lol.
At least for 1.8.9 from Forge. Just look at net.minecraft.item.ItemStack
While it's possible to implement it doesn't seem like the most urgent of issues.

from skyblockaddons.

t-brieger avatar t-brieger commented on June 18, 2024

I cant seem to manage to set up my development environment correctly so I cant test it, but that should be fixed by changing the line

main.getInventoryUtils().getInventoryDifference(p.inventory.mainInventory); //PlayerListener.java L349

to

ItemStack[] combinedInventory = new ItemStack[p.inventory.mainInventory.length + p.inventory.armorInventory.length];
System.arraycopy(p.inventory.mainInventory, 0, combinedInventory, 0, p.inventory.mainInventory.length);
System.arraycopy(p.inventory.armorInventory, 0, combinedInventory, p.inventory.mainInventory.length, p.inventory.armorInventory.length);
main.getInventoryUtils().getInventoryDifference(combinedInventory);

from skyblockaddons.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.