Coder Social home page Coder Social logo

lita-flowdock's People

Contributors

apanzerj avatar bhouse avatar tgraham avatar

Stargazers

avatar avatar avatar avatar avatar avatar avatar avatar avatar

Watchers

avatar avatar avatar

Forkers

tgraham muffinista lethalpaga zendesk cloudxtreme heathsnow jens mexisme ksreenivas

lita-flowdock's Issues

Long Startup times for large organisations

In our organisation we have ~1000 members. When this adapter starts up, it caches all of them as User objects which can take quite some time (~15 minutes). This is rather silly when some bots may only be added to a single private flow with ~20 members. As such, this adapter should be smarter in which users it loads - it should only load members of the flows which it is told to join.

Bundle install error

When following the Getting Started guide there is a failure executing this step:

bundle install --path vendor/bundle

using the latest development vagrant box provided by lita.

Error Snippet:

Gem::Ext::BuildError: ERROR: Failed to build gem native extension.

The error is related to the eventmachine gem.

Respond to private messages

the flowdock adapter should allow lita to respond to private messages. It should be configurable to:

  • :disabled - don't respond to any private messages
  • :help - only respond to help commands in private messages
  • :enabled - respond to any private message

testing-room doesn't work

Create a flowdock room called testing-room

Add your bot to the room

Now try to response.reply and notice that you get a 403 for some reason.

Allow bot to respond in a message thread

One of the best features of Flowdock are message threads:

In order to thread a message, we need to respond with the original message id in the api call:

# Send a comment to message 1234
client.chat_message(flow: flow_id, content: "Now I'm commenting!", message: 1234)

I'm not sure how Lita will track the message id when it signals the robot.receive(message), so handlers can pass the message id back to send_messages, maybe with an Lita extension?

Properly exit the EventMachine run loop

Right now the EventMachine.run loop is being closed on shutdown by calling source.close from outside the loop

https://github.com/bhouse/lita-flowdock/blob/master/lib/lita/adapters/flowdock.rb#L27-L35
https://github.com/bhouse/lita-flowdock/blob/master/lib/lita/adapters/flowdock/connector.rb#L56-L58

This triggers a RuntimeError, which is currently being rescued:

[2015-02-08 05:42:18 UTC] INFO: Connected to flowdock streaming API
^C[2015-02-08 05:42:21 UTC] ERROR: "Connection lost. Reconnecting."
/vagrant/vendor/bundle/ruby/2.1.0/gems/eventmachine-1.0.6/lib/em/connection.rb:266:in `close_connection': eventmachine not initialized: evma_close_connection (RuntimeError)
    from /vagrant/vendor/bundle/ruby/2.1.0/gems/eventmachine-1.0.6/lib/em/connection.rb:266:in `close_connection'
    from /vagrant/vendor/bundle/ruby/2.1.0/gems/em-http-request-1.1.2/lib/em-http/http_connection.rb:198:in `unbind'
    from /vagrant/vendor/bundle/ruby/2.1.0/gems/em-eventsource-0.2.0/lib/em-eventsource.rb:107:in `close'
    from /vagrant/lita-flowdock/lib/lita/adapters/flowdock/connector.rb:57:in `shut_down'
    from /vagrant/lita-flowdock/lib/lita/adapters/flowdock.rb:34:in `shut_down'
    from /vagrant/lita-flowdock/lib/lita/adapters/flowdock.rb:29:in `rescue in run'
    from /vagrant/lita-flowdock/lib/lita/adapters/flowdock.rb:19:in `run'
    from /vagrant/vendor/bundle/ruby/2.1.0/gems/lita-4.2.0/lib/lita/robot.rb:69:in `run'
    from /vagrant/vendor/bundle/ruby/2.1.0/gems/lita-4.2.0/lib/lita.rb:79:in `run'
    from /vagrant/vendor/bundle/ruby/2.1.0/gems/lita-4.2.0/lib/lita/cli.rb:77:in `start'
    from /vagrant/vendor/bundle/ruby/2.1.0/gems/thor-0.19.1/lib/thor/command.rb:27:in `run'
    from /vagrant/vendor/bundle/ruby/2.1.0/gems/thor-0.19.1/lib/thor/invocation.rb:126:in `invoke_command'
    from /vagrant/vendor/bundle/ruby/2.1.0/gems/thor-0.19.1/lib/thor.rb:359:in `dispatch'
    from /vagrant/vendor/bundle/ruby/2.1.0/gems/thor-0.19.1/lib/thor/base.rb:440:in `start'
    from /vagrant/vendor/bundle/ruby/2.1.0/gems/lita-4.2.0/bin/lita:6:in `<top (required)>'
    from /vagrant/vendor/bundle/ruby/2.1.0/bin/lita:23:in `load'
    from /vagrant/vendor/bundle/ruby/2.1.0/bin/lita:23:in `<main>'

any release plan ?

Hello,

any plan to release the new version with the changes applied after May release ?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.