Coder Social home page Coder Social logo

Comments (8)

vk22 avatar vk22 commented on June 25, 2024 1

Works like a charm! Thank you very much!

from node-taglib-sharp.

benrr101 avatar benrr101 commented on June 25, 2024

Hi, @vk22, apologies for the delay in getting back to you. This project has taken a bit of a back seat as work has given me plenty of stuff to work on (and my mom passed away a couple weeks ago which has taken up most of my time lately).

After some experimentation, I was able to reproduce your issue with a hex editor, kid3, foobar2000, and VLC on Windows. It looks like the issue is caused by the node-taglib-sharp library not properly updating AIFF length property in the header of the file. This property tells any decoders how long the file is. Not updating this value is not an issue when reading tags with the node-taglib-sharp library (and apparently in VLC, kid3, and itunes) because the library scans the file for the ID3 chunk header, regardless of how many bytes the property says the file is. Other libraries appear to only scan the file for as many bytes as the property says, which means it'll skip reading the tags node-taglib-sharp creates.

I'm working on a hotfix and will let you know when it is ready.

from node-taglib-sharp.

vk22 avatar vk22 commented on June 25, 2024

@benrr101 thanks a lot for your answer. In no case I didn't want to rush you with this, I understand that this is not your main job. And I am very sorry for your loss. Be strong.

from node-taglib-sharp.

benrr101 avatar benrr101 commented on June 25, 2024

Good news, the fix is out v4.0.2 https://www.npmjs.com/package/node-taglib-sharp/v/4.0.2

It was a pretty easy fix, and to be honest I'm happy to have someone interested enough in the project to point out something not working right. Also thanks for the condolences 🙏

One quick thing I'll add - I completely forgot there's a much easier way to create an IPicture:

import {Picture} from "node-taglib-sharp";

const pic = Picture.fromPath("path/to/picture.jpg");
// pic.type defaults to FrontCover if you give it a picture, but you can always manually change for other types.

Let me know if you have any other issues 👍

from node-taglib-sharp.

vk22 avatar vk22 commented on June 25, 2024

Thank you very much! I will try it today and return with result.
Have a nice week!

from node-taglib-sharp.

vk22 avatar vk22 commented on June 25, 2024

Hey mate! Sorry, i have a question: which the best way to convert aif to flac with keeping all meta tags using node.js?
Thank you for answer.
Regards!

from node-taglib-sharp.

benrr101 avatar benrr101 commented on June 25, 2024

Glad to hear it worked!
As for converting AIFF to FLAC using node.js... I'm not sure. The node-taglib-sharp library is just for doing tagging and reading properties of the files. If I were doing it, I'd probably try to use ffmpeg since it's very versatile for transcoding files. I've used it from the command line quite a bit to verify tags while I'm testing node-taglib-sharp stuff, so at the very least it's aware of tagging. There's at least one node.js binding for it you can check out https://www.npmjs.com/package/ffmpeg

from node-taglib-sharp.

vk22 avatar vk22 commented on June 25, 2024

Thank you for answer! I use ffmpeg now.
Regards!

from node-taglib-sharp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.