Comments (8)
Works like a charm! Thank you very much!
from node-taglib-sharp.
Hi, @vk22, apologies for the delay in getting back to you. This project has taken a bit of a back seat as work has given me plenty of stuff to work on (and my mom passed away a couple weeks ago which has taken up most of my time lately).
After some experimentation, I was able to reproduce your issue with a hex editor, kid3, foobar2000, and VLC on Windows. It looks like the issue is caused by the node-taglib-sharp library not properly updating AIFF length property in the header of the file. This property tells any decoders how long the file is. Not updating this value is not an issue when reading tags with the node-taglib-sharp library (and apparently in VLC, kid3, and itunes) because the library scans the file for the ID3
chunk header, regardless of how many bytes the property says the file is. Other libraries appear to only scan the file for as many bytes as the property says, which means it'll skip reading the tags node-taglib-sharp creates.
I'm working on a hotfix and will let you know when it is ready.
from node-taglib-sharp.
@benrr101 thanks a lot for your answer. In no case I didn't want to rush you with this, I understand that this is not your main job. And I am very sorry for your loss. Be strong.
from node-taglib-sharp.
Good news, the fix is out v4.0.2 https://www.npmjs.com/package/node-taglib-sharp/v/4.0.2
It was a pretty easy fix, and to be honest I'm happy to have someone interested enough in the project to point out something not working right. Also thanks for the condolences 🙏
One quick thing I'll add - I completely forgot there's a much easier way to create an IPicture
:
import {Picture} from "node-taglib-sharp";
const pic = Picture.fromPath("path/to/picture.jpg");
// pic.type defaults to FrontCover if you give it a picture, but you can always manually change for other types.
Let me know if you have any other issues 👍
from node-taglib-sharp.
Thank you very much! I will try it today and return with result.
Have a nice week!
from node-taglib-sharp.
Hey mate! Sorry, i have a question: which the best way to convert aif to flac with keeping all meta tags using node.js?
Thank you for answer.
Regards!
from node-taglib-sharp.
Glad to hear it worked!
As for converting AIFF to FLAC using node.js... I'm not sure. The node-taglib-sharp library is just for doing tagging and reading properties of the files. If I were doing it, I'd probably try to use ffmpeg since it's very versatile for transcoding files. I've used it from the command line quite a bit to verify tags while I'm testing node-taglib-sharp stuff, so at the very least it's aware of tagging. There's at least one node.js binding for it you can check out https://www.npmjs.com/package/ffmpeg
from node-taglib-sharp.
Thank you for answer! I use ffmpeg now.
Regards!
from node-taglib-sharp.
Related Issues (20)
- Version 5.2.3 breaks reading of mp3 picture.data for some files HOT 4
- bitrate will be 0 on some files HOT 2
- "Granular position is too large to be handled with this version of node-taglib-sharp" when parsing ogg file HOT 7
- Remove Ogg granule position safe integer check and make granule position a number HOT 1
- Support for M4A HOT 7
- use in browser HOT 5
- Matroska tag docs didn't get generated HOT 1
- Question - error setting title HOT 2
- Question - Setting the text information frames in a id3v2TextInformationFrame HOT 2
- Id3v2FrameIdentifier doc and possible bug ? HOT 4
- Named export not found HOT 4
- Pictures cannot display in windows file browser. HOT 4
- ID3v2 tags at end of file not showing up in players
- Throwing error: `Argument null: ${name} was not provided` HOT 10
- 'Cannot set property ByteVector' error on load of module HOT 3
- id3v2 frameId RGAD causes failure to read tags HOT 4
- Add Legacy ReplayGain Frame Support
- Why Tag class has no accessor for 'artist' ? HOT 1
- poor performance when saving picture HOT 3
- wrong duration of `.mp3` and `.wav` HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node-taglib-sharp.