Comments (4)
@digimezzo thanks for reporting this - yeah, the last release was supposed to fix the way that GEOB frames were handled.
Looking into the file, I can see it has a GEOB frame that is of size 1394 bytes w/description "RealJukebox:Metadata". GEOB frames (General Encapsulated Object) are included in the Pictures
property (at this point Picture is a bit of a misnomer since it's generally any kind of attachment to the file). It sounds like it might be necessary to tweak your usage of the picture data in your app such that PictureType.NotAPicture
is filtered out of Pictures
.
I puzzled over this for a long while... I have a small utility program that dumps tags, and on debugging that file, it wouldn't show the GEOB as part of Pictures
. But looking at the TagLib# source, Pictures
simply gets all frames that inherit from AttachmentFrame
. Upon closer inspection, the version of TagLib# my utility program was built against is using an older version of TagLib# where only AttatchedPictureFrame
was being returned. So at some point, the TagLib# behavior was updated to include GEOB frames in Pictures
.
Let me know your thoughts
from node-taglib-sharp.
@digimezzo any more thoughts on this, or can I close it?
from node-taglib-sharp.
@benrr101 Sorry, I meant to give this issue some time but lost track of it due to other tasks. I just tried your recommendation concerning PictureType.NotAPicture
. Filtering out Pictures with PictureType.NotAPicture
solves the problem. As far as I'm concerned, this issue can be closed. Thank you for the help.
from node-taglib-sharp.
Thanks for confirming. I'll go ahead and close out, but as always please let me know if there's other issues!
from node-taglib-sharp.
Related Issues (20)
- bitrate will be 0 on some files HOT 2
- Error setting tags for m4a files HOT 26
- Remove Ogg granule position safe integer check and make granule position a number HOT 1
- Support for M4A HOT 7
- use in browser HOT 5
- Matroska tag docs didn't get generated HOT 1
- Question - error setting title HOT 2
- Question - Setting the text information frames in a id3v2TextInformationFrame HOT 2
- Id3v2FrameIdentifier doc and possible bug ? HOT 4
- Named export not found HOT 4
- Pictures cannot display in windows file browser. HOT 4
- ID3v2 tags at end of file not showing up in players
- Throwing error: `Argument null: ${name} was not provided` HOT 10
- 'Cannot set property ByteVector' error on load of module HOT 3
- id3v2 frameId RGAD causes failure to read tags HOT 4
- Add Legacy ReplayGain Frame Support
- Why Tag class has no accessor for 'artist' ? HOT 1
- poor performance when saving picture HOT 3
- wrong duration of `.mp3` and `.wav` HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node-taglib-sharp.