Comments (4)
Hi @digimezzo, thanks for the report and the investigation. I think this is actually a duplicate of #85 and you were really close to pinpointing what I think is the issue. A while back to improve the memory requirements for ID3v2 and unify the identifiers to make converting between ID3v2 versions easier, I went to a static list of identifiers from the ID3v2 docs. When reading the frames, the frame identifier is converted to a string and used as the index into the static list. Since RGAD
is a non-standard identifier, pulling it up from the static list returns undefined
.
Rather than allow that to throw later on, it should be creating an on-the-fly identifier and the frame factory should treat it as an UnknownFrame. I have a proposed solution for this but was waiting for the #85 reporter to test it out. Can you try out this beta version and see if it resolves the issue? If so, I can publish it as a hotfix in a couple days https://www.npmjs.com/package/node-taglib-sharp/v/5.2.1-fixid3v2nonstandardframes.1
from node-taglib-sharp.
@benrr101 I tried the beta version and it fixes the Argument null: id was not provided
error. Thank you for the fix.
from node-taglib-sharp.
@digimezzo, thanks for testing! I just published the v5.2.2 release that contains the fix https://www.npmjs.com/package/node-taglib-sharp/v/5.2.2
Interestingly, the RGAD
frame isn't totally non-standard, it's a legacy ReplayGain frame format. As such, I think it'd be useful to add support for reading it and optionally writing it. However, I'll close this one and track that issue on another issue.
from node-taglib-sharp.
I have a proposed solution for this but was waiting for the #85 reporter to test it out.
Sorry @benrr101 never got to testing.
from node-taglib-sharp.
Related Issues (20)
- Version 5.2.3 breaks reading of mp3 picture.data for some files HOT 4
- bitrate will be 0 on some files HOT 2
- Error setting tags for m4a files HOT 26
- Data Retrieval issues HOT 1
- Support for M4A HOT 7
- use in browser HOT 5
- Matroska tag docs didn't get generated HOT 1
- Question - error setting title HOT 2
- Question - Setting the text information frames in a id3v2TextInformationFrame HOT 2
- Id3v2FrameIdentifier doc and possible bug ? HOT 4
- Named export not found HOT 4
- Pictures cannot display in windows file browser. HOT 4
- ID3v2 tags at end of file not showing up in players
- Throwing error: `Argument null: ${name} was not provided` HOT 10
- 'Cannot set property ByteVector' error on load of module HOT 3
- Add Legacy ReplayGain Frame Support
- Why Tag class has no accessor for 'artist' ? HOT 1
- poor performance when saving picture HOT 3
- wrong duration of `.mp3` and `.wav` HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node-taglib-sharp.