barrycenter / bamsettings Goto Github PK

Hi Barry,

Thanks for a great job you do!
I consider to use your BAMSettings for one of my projects and go over your code.
Just found a few minor memory leaks:

1. you should release propertyListName and paneTitle in BAMSettings dealloc method since you make copy of strings in init methods;

2)self.tableView = [[UITableView alloc] initWithFrame:CGRectZero style:UITableViewStyleGrouped]; in viewDidLoad method leaks since tableView is retain property. By the way since you subclass UITableViewController, tableView is automatically initialized to a plain table, so you can just change its style only without reinitialization.

Thanks again,
Alex

Hi,
when I specify the KeyboardType of a text input, it is ignored by BAMSettings.

            <key>KeyboardType</key>
            <string>NumberPad</string>

This will show up a normal keyboard. If I open the settings via the Preferences app, it is shown correctly