ayl / vaextractor Goto Github PK

These tests will show the error:

    	def test_logmar_16
		a = VAExtractor.new
		val, _ = a.logmar([20, 16, '', '', '', '', ''])
		assert(val != nil)
	end

	def test_logmar_19minus
		a = VAExtractor.new
		val, _ = a.logmar(["20", "19", "-", nil, nil, nil, nil, nil, nil, nil])
		assert(val != nil)
	end

This will cause the manual variable to be nil:

And will cause an error here since lva[0] cannot be compared to bcva['O?'][1].

I bypassed the error by supplying next if lva[0].nil?, but this just ignores those values.

This can be replicated with the following test:

def test_scalp_does_not_error
	a = VAExtractor.new
	a.extract('SCALP ')  # the 'LP ' will be captured
end

The regular expression incorrectly identifies some text as a potential VA score. If no VA score is found, these will raise an ErrorLateralityNotFound. (E.g., "LP " is captured.)

NB: Under the current code, other errors may occur before since boundary conditions aren't checked, but this is the underlying issue. (E.g.,