Coder Social home page Coder Social logo

talismans's Introduction

talismans's People

Contributors

0ft3n avatar willfp avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar

talismans's Issues

Skill_XP_multiplier not working for EcoSkills if McMMO is on a server

Describe the bug
If both EcoSkill and McMMO are used together, the Skill_XP_muliplier wont work for EcoSkills.

To Reproduce
Steps to reproduce the behavior:

  1. Use both McMMO and Ecoskills + Talisman
  2. Create a Talisman for Woodcutting or something that boosts EcoSkills XP
  3. Should not be working
  4. Remove McMMO
  5. Should work now

Expected behavior
It should still work if McMMO is used like it in earlier versions.

Screenshots
If applicable, add screenshots to help explain your problem.

Server Information (please complete the following information):

  • Paper version git-Paper-216 (MC: 1.18.1) (Implementing API version 1.18.1-R0.1-SNAPSHOT) (Git: 30cb7d0)
  • eco-6.27.2-all, EcoSkills v1.20.27, Talismans v5.29.0

Additional Context
I've also been getting these Errors when starting up (EcoSkill Names):
image

[BUG] [CONFIGURATION] Missing cooldown message in the plugin configuration of lang.yml.

Describe the bug
If I wanted to translate the lines from the plugin responsible for displaying the inscription about the recharge of the talisman, I came across the problem of the complete absence of this line in the lang.yml file. I also didn't find this line in the plugin file on github.

Screenshots
image
image
image

Server Information (please complete the following information):

  • Version: git-Paper-267 (MC: 1.18.2) (Implementing API version 1.18.2-R0.1-SNAPSHOT) (Git: e7d928a)
  • Version: eco v6.30.2 and Talismans v5.36.0

Additional context
See ticket: https://discord.com/channels/452518336627081236/957340104626692137

Talismans - Error with Kingdoms

Describe the bug
After uploading talismans, a bunch of errors appear in the console.
Talismans have only been uploaded and no player has them yet.

Kingdoms ver: Kingdom: 1.12.2.0.0.1-BETA
https://www.spigotmc.org/resources/kingdomsx.77670/

To Reproduce
Steps to reproduce the behavior:
Just upload talismans to the server with kingdoms plugin
https://pastebin.com/NSUaGddi

Server Information (please complete the following information):

  • This server is running Pufferfish version git-Pufferfish-47 (MC: 1.18.1) (Implementing API version 1.18.1-R0.1-SNAPSHOT) (Git: a786526 on HEAD)
  • Version of plugin and eco (/ver eco, /ver <plugin>)
    image

feather_step causes not being able to trigger pressure plates

Describe the bug
The feather_step effect causes not being able to trigger stone pressure plates

To Reproduce

  1. Make a talisman with feather_step
  2. Step on a pressure plate with the talisman
  3. See error

Expected behavior
It should active.

Server Information:

  • Paper version git-Paper-214 (MC: 1.18.1) (Implementing API version 1.18.1-R0.1-SNAPSHOT) (Git: bfa50ad)
  • eco-6.25.2-all, Talismans v5.27.0

Talismans bag Bug

Describe the bug
I am able to put items which are not talismans in the talismans bag

To Reproduce
Description explains it all

Expected behavior
It should not allow me to put any item in the talismans bag except the talismans

Screenshots
If applicable, add screenshots to help explain your problem.

Server Information (please complete the following information):
Server Version: 1.18.2
Plugin Version: Latest

Additional context
Add any other context about the problem here.

Request: Multiple Independent Lores Lines

Hello!

I'm requesting the addition of multiple independent lore lines. It would be nice if lore lines weren't limited by on each other like they are now with the 'wrap' method. If I want 20 characters on line 5 but only 2 characters on line 1, this should be possible, and honestly this feels like an oversight.

Please add this as it stands right now this would be amazing plugin is useless to me.

Talismans not fully Loading on Server join

When joining my Server, not all Talismans seem to load. They do load after the first restart but after rejoining once, I have to
manually reselect them in my inventory.

Steps to reproduce the behavior:

  1. Use my Config I guess
  2. Give yourself a vibrance talisman (as that talisman doesnt work and some others like defense and strengh talisman which only works with ecoskills)
  3. Join Server, (They should be working)
  4. Rejoin (shouldnt be working anymore)
  5. Reselect them in inventory or drop and pick them up (should be working again)

Expected behavior
Instantly load all talismans without having to reselect some on serverjoin

Server Information (please complete the following information):

  • Version: Paper version git-Paper-205 (MC: 1.18.1) (Implementing API version 1.18.1-R0.1-SNAPSHOT) (Git: 36a1650)
  • Version of plugin and eco: eco-6.25.2-all, Ta
    lismans v5.25.5, EcoSkills v1.20.22

Config as .txt file because I couldnt it add as YML:
talismans.txt

Skill_xp_multiplier causing too much xp on the first levels

Describe the bug
When using the Skill_xp_multiplier for a talisman it and then enchanting while being level 0 in the enchanting
skill it will give the amount of the 32bit integer as XP. In my Case: I have a Talisman that multiplies by 1.5x the
XP and one that multiplies by 2x the XP. If I have both talismans and am Level 0 in enchanting Ill instantly reach max lvl.

To Reproduce
Steps to reproduce the behavior:

  1. I guess use the same Talismans as me: 1 = 100% XP boost, 2 = 50% XP boost (Both for enchanting)
  2. Enchant an Item while being lvl 0

Expected behavior
It shouldn't create infinite XP while being lvl 0

Screenshot 2022-05-06 005916
(Talismans in the Screen are those meantioned)

Server Information (please complete the following information):

Bug 2 types of talisman cause complete immortality in players!

Describe the bug
The error is related to the fact that the player, having the talisman "Necrosis" or "immunity", then he becomes immortal

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Install any version of the plugin not lower than talismans v 5.103.0, and take the "Necrosis" or "immunity" talisman in your hand, congratulations, you are immortal'

Expected behavior
no bugs

Server Information (please complete the following information):

  • Version: Mirai 1.19.2-R0.1-SNAPSHOT
  • Version of plugin and eco (eco-6.41.1-all, Talismans 5.112.0)

Additional context
I decided to carefully find after which version this bug happened, I noticed that in version 5.102.3 everything works fine and there is no bug, but if I install the version of the Talismans plugin v5.103.0 and higher, then there is a bug and it is not corrected!
Which says that the bug appeared in version 5.103.0, I think this will make it easier for you to find it

Here is a video of the bug: https://youtu.be/lbaPmnX19aU

InvocationTargetException / LinkageError

Version 5.126.0 of the plugin gives me these exceptions in the server console log (Paper 1.19.2) on startup:

[23:03:49 INFO]: [eco] Loaded eco
[23:03:49 WARN]: java.lang.reflect.InvocationTargetException
[23:03:49 WARN]: 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[23:03:49 WARN]: 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
[23:03:49 WARN]: 	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
[23:03:49 WARN]: 	at java.base/java.lang.reflect.Method.invoke(Unknown Source)
[23:03:49 WARN]: 	at eco-6.44.1-all.jar//com.willfp.eco.internal.config.EcoConfigHandler.callUpdate(EcoConfigHandler.kt:25)
[23:03:49 WARN]: 	at eco-6.44.1-all.jar//com.willfp.eco.core.EcoPlugin.reload(EcoPlugin.java:563)
[23:03:49 WARN]: 	at eco-6.44.1-all.jar//com.willfp.eco.core.EcoPlugin.afterLoad(EcoPlugin.java:538)
[23:03:49 WARN]: 	at org.bukkit.craftbukkit.v1_19_R1.scheduler.CraftTask.run(CraftTask.java:101)
[23:03:49 WARN]: 	at org.bukkit.craftbukkit.v1_19_R1.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:483)
[23:03:49 WARN]: 	at net.minecraft.server.MinecraftServer.v(MinecraftServer.java:1114)
[23:03:49 WARN]: 	at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:305)
[23:03:49 WARN]: 	at java.base/java.lang.Thread.run(Unknown Source)
[23:03:49 WARN]: Caused by: java.lang.LinkageError: loader constraint violation: when resolving method 'com.willfp.eco.core.gui.menu.Menu com.willfp.eco.core.gui.GUIHelperExtensions.menu(int, kotlin.jvm.functions.Function1)' the class loader 'Talismans v5.126.0.jar' @67978176 of the current class, com/willfp/talismans/bag/TalismanBag, and the class loader 'eco-6.44.1-all.jar' @761e2cf1 for the method's defining class, com/willfp/eco/core/gui/GUIHelperExtensions, have different Class objects for the type kotlin/jvm/functions/Function1 used in the signature (com.willfp.talismans.bag.TalismanBag is in unnamed module of loader 'Talismans v5.126.0.jar' @67978176, parent loader java.net.URLClassLoader @4445629; com.willfp.eco.core.gui.GUIHelperExtensions is in unnamed module of loader 'eco-6.44.1-all.jar' @761e2cf1, parent loader java.net.URLClassLoader @4445629)
[23:03:49 WARN]: 	at Talismans v5.126.0.jar//com.willfp.talismans.bag.TalismanBag.update(TalismanBag.kt:63)
[23:03:49 WARN]: 	... 12 more

FYI, I have the "eco" library installed, but not EcoSkills or EcoJobs.

Delay to use the talisman.

Is your feature request related to a problem? Please describe.
I suggest adding a delay to the "mine_radius" effect. That is, it can only be used for 5 minutes, and then there will be a 60-minute cooldown to restore the talisman.
Since breaking blocks and wasting only the durability of the tool is not very unbalanced talisman. You can make it work below some height and in a certain biome, but it won't fix the balance of this effect much.

Describe alternatives you've considered
I suggest adding an argument for restoration and use.

Talismans bag

There is a problem with refreshing the talismans. After introducing the carry bag for talismans during relogation, you need to remove them again and put these talismans back in the bag for their bonuses to take effect. The problem occurs only with the bag, if you have in your inventory / enderchest or shulker + you have this option in config, everything works fine, but if it is a bag, you have to remove it and put the talisman back in the bag

image
image

Request: Define Bonus Amount

Instead of a percentage, perhaps add a define amount like +5 bow damage

In this example the bow would do an additional flat +5 damage rather than +5% variable percent damage

Permission bug

Describe the bug
Hey an issue i'm getting is if I put the permission "talismans.fromtable.*" to false on the lowest group and on a higher group I give the permission to craft the "alchemy_1" talisman it won't work. Maybe talismans.fromtable.* is overriding everything. After trying to put the permission to craft the "alchemy_1" talisman on false it will still override it and I won't be able to craft it.

To Reproduce
Steps to reproduce the behavior:

  1. Give the permission talismans.fromtable.* on false for the lowest group you have (weight)
  2. On a higher group give the permission to craft a certain talisman
  3. Try and craft it and it will not work
  4. Vice versa if you try to put the specific talisman craft permission on false it won't work.

Expected behavior
I should be able to craft it.

Screenshots
none

Server Information (please complete the following information):

  • Version: This server is running Paper version git-Paper-409 (MC: 1.17.1) (Implementing API version 1.17.1-R0.1-SNAPSHOT) (Git: c53577e on ver/1.17.1)
    You are running the latest version
  • Version of plugin and eco (/ver eco, /ver <plugin>)
    Eco: 6.25.2
    Talismans: 5.27.0

Additional context
Add any other context about the problem here.

add_stat and permanent_potion_effect are not activated when connected to the server.

add_stat and permanent_potion_effect are not activated when connected to the server and players must remove all talismans from the talisman bag, throw them on the ground and put them back in the talisman bag. The effects are only automatically triggered the first time a player connects after a server restart.

this bug has been around forever.

Server Information:

  • Version: git-Paper-190 (MC: 1.19.2)
  • Version of plugin and eco, eco: 6.42.0, talismans: 5.115.0

Damage Filters are not working

Describe the bug
Damage Filters are not working.

To Reproduce
Steps to reproduce the behavior:

  1. Give yourself necrosis Talisman
  2. Try to take damage

Server Information (please complete the following information):

  • Version: git-Purpur-1778 (MC: 1.19.2)*
  • Version: eco 6.41.1, Talismans 5.110.0

Add custommodeldata to Talismans

Many servers use texture pack and custommodeldata plays an important role. I can't find out how to use it in wiki so I guess this option is not available.
This might be applied to your other plugins. :D

Talisman loading issues

(Updated the whole thing to 1 Juli 2022)
Describe the bug
When rejoining a Server, some Talismans wont load at all and players have to reselect the Shulker with Talismans or just the Talisman itself. (Meaning, lifting the item and dropping it in the slot again)

To Reproduce
Steps to reproduce the behavior:

  1. Not sure, just use Talismans with my config
  2. Give yourself the Vibrance Talisman
  3. Test the effect (Should see more Hearts, maybe its required to drop the item and pick it up again)
  4. Restart the Server
  5. Upon first joining the Server after restart with the talisman in your inventory/ec they will work (Hearts will be active)
  6. After rejoining the 2nd time they wont load, fixed only by lifting the Shulkerbox/talisman and dropping it in the slot again

Expected behavior
Talismans should load after rejoining Talismans.

Server Information:

  • Current: git-Purpur-1685 (MC: 1.19)
  • Talismans v5.80.0, eco-6.37.1-all

Talismans
talismans.zip

Talismans not displaying properly in Auction House

Describe the bug
Talismans don't display properly inside of Auction House GUI. Normally items should display price, listing time, and seller, but talismans only display as they would normally inside your inventory.
(Also happens with mob heads from Eco enchants beheading enchantment)

To Reproduce
Steps to reproduce the behavior:

  1. Install Auction House plugin (https://www.spigotmc.org/resources/auctionhouse.61836/)
  2. List a talisman (or eco mob head) on the auction house using "/ah list [price]" while holding the item
  3. Use /ah to view the auction house
  4. See error (mob heads from enchantment display with the name eco's head)

Expected behavior
When you list the item it should display with price, and info on how to click.

Screenshots
unknown
Capture

Server Information:

  • Paper version git-Paper-277 (MC: 1.18.2) (Implementing API version 1.18.2-R0.1-SNAPSHOT) (Git: 87e11bf)
  • Eco version 6.31.3
  • Talismans version 5.12.2
  • EcoEnchants version 8.55.0

talisman 1.11.0 error with Yatopia(17) server

selfcompiled talisman on Yatopia, continuation of EcoEnchants errors, the saga continues.

[16:21:34 INFO]: [Talismans] Enabling Talismans v1.11.0
[16:21:34 INFO]: [Talismans]
[16:21:34 INFO]: [Talismans] Loading Talismans
[16:21:34 INFO]: [Talismans] Loaded integrations:
[16:21:34 ERROR]: Error occurred while enabling Talismans v1.11.0 (Is it up to date?)
java.lang.NoClassDefFoundError: com/willfp/talismans/proxy/proxies/SkullProxy
at com.willfp.talismans.display.TalismanDisplay.displayTalisman(TalismanDisplay.java:90) ~[?:?]
at com.willfp.talismans.talismans.Talisman.update(Talisman.java:207) ~[?:?]
at com.willfp.talismans.talismans.Talisman.(Talisman.java:175) ~[?:?]
at com.willfp.talismans.talismans.talismans.ZombieTalisman.(ZombieTalisman.java:16) ~[?:?]
at com.willfp.talismans.talismans.Talismans.(Talismans.java:52) ~[?:?]
at com.willfp.talismans.commands.TabcompleterTalgive.(TabcompleterTalgive.java:24) ~[?:?]
at com.willfp.talismans.commands.CommandTalgive.getTab(CommandTalgive.java:28) ~[?:?]
at com.willfp.eco.util.command.AbstractCommand.register(AbstractCommand.java:139) ~[?:?]
at java.util.Arrays$ArrayList.forEach(Arrays.java:4390) ~[?:?]
at com.willfp.eco.util.plugin.AbstractEcoPlugin.onEnable(AbstractEcoPlugin.java:263) ~[?:?]
at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:263) ~[server.jar:git-Yatopia-17]
at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:380) ~[server.jar:git-Yatopia-17]
at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:483) ~[server.jar:git-Yatopia-17]
at org.bukkit.craftbukkit.v1_16_R3.CraftServer.enablePlugin(CraftServer.java:501) ~[server.jar:git-Yatopia-17]
at org.bukkit.craftbukkit.v1_16_R3.CraftServer.enablePlugins(CraftServer.java:415) ~[server.jar:git-Yatopia-17]
at net.minecraft.server.v1_16_R3.DedicatedServer.init(DedicatedServer.java:227) ~[server.jar:git-Yatopia-17]
at net.minecraft.server.v1_16_R3.MinecraftServer.w(MinecraftServer.java:943) ~[server.jar:git-Yatopia-17]
at net.minecraft.server.v1_16_R3.MinecraftServer.lambda$a$0(MinecraftServer.java:175) ~[server.jar:git-Yatopia-17]
at java.lang.Thread.run(Thread.java:834) [?:?]
Caused by: java.lang.ClassNotFoundException: com.willfp.talismans.proxy.proxies.SkullProxy
at java.net.URLClassLoader.findClass(URLClassLoader.java:471) ~[?:?]
at org.bukkit.plugin.java.PluginClassLoader.findClass(PluginClassLoader.java:182) ~[server.jar:git-Yatopia-17]
at org.bukkit.plugin.java.PluginClassLoader.findClass(PluginClassLoader.java:111) ~[server.jar:git-Yatopia-17]
at java.lang.ClassLoader.loadClass(ClassLoader.java:589) ~[?:?]
at java.lang.ClassLoader.loadClass(ClassLoader.java:522) ~[?:?]
... 19 more
[16:21:34 INFO]: [Talismans] Disabling Talismans v1.11.0

[BUG] Argument "self_as_victim" not work or mutators: - id: player_as_victim not work.

self_as_victim - not worked.

To Reproduce
effects:

  • id: damage_nearby_entities
    args:
    damage: 2
    radius: 25
    damage_as_player: true
    damage_self: false
    triggers:
    • alt_click
  • id: strike_lightning
    args:
    amount: 1
    damage: 15
    self_as_victim: true
    delay: 1
    mutators:
    • id: player_as_victim
      triggers:
    • kill
  • id: spawn_particle
    args:
    particle: portal
    amount: 100
    triggers:
    • kill

Expected behavior
I expect that, when killing any creature with the "damage_nearby_entities" effect, with the "damage_as_player" argument (damage from a player who has a talisman in his hands), lightning will strike the player holding the talisman from the "strike_lightning" effect with the "self_as_victim" parameter (the player as a target), and the "player_as_victim" mutator (as suggested by the support with Discord).

Server Information (please complete the following information):

  • Version: Paper version git-Paper-265 (MC: 1.18.2) (Implementing API version 1.18.2-R0.1-SNAPSHOT) (Git: 993f828)
  • Version of plugin and eco: > eco version 6.29.2, Talismans version 5.35.0

Additional context
Add any other context about the problem here.

Add max_health effect

I want to limit max health, with talismans.
For example 10 health points instead of 20

Kicking from the server when 50+ talismans are created

After creating approximately more than 50 talismans, it is not possible to connect to the server.
Messages in the console:
Lost connection: internal exception:
lost connection: internal Exception: net.minecraft.network.PacketEncoder$PacketTooLargeException: PacketTooLarge - PacketPlayOutRecipeUpdate is 2218477. Max is 2097152

Server Information

  • Version: 1.18.1 Purpur-1566
  • Version of plugin and eco: Eco: 6.27.0, talismans: 5.28.1

[Feature] Freeze effect like "ignite"

Is your feature request related to a problem? Please describe.
I have a great need to create items that can freeze (lower the temperature) the player through the standard frostbite effect that was added to minecraft 1.18 together with loose snow.

Describe the solution you'd like

  • id: freeze
    args:
    damage_per_tick: 2 - How much damage will the damage or target receive if the frostbite effect is applied to it.
    ticks: 100 How long will the damage be dealt in ticks.
    accumulation: 100 How quickly the frostbite effect will accumulate in battle (accumulation with each blow), if there is no effect, it is applied instantly
    triggers:
    • Any trigger.

Describe alternatives you've considered

There is no alternative, this effect is not supported by any of the mechanisms available to me.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.