asok / all-the-icons-ivy Goto Github PK

Observed:
counsel-find-file displays some incorrect generic icons for directories:

Expected: Detect when candidate is a directory and use (all-the-icons-octicon "file-directory") icon.

I noticed that a directory symbol in all-the-icons-ivy shows is as a blank page symbol that is flipped on the corner. Which is completely different from the regular directory symbol which shows up in all-the-icons.
Is that expected?

Software versions
emacs: github emacs-26 branch (Labeled 26.1 - current)
ivy: 2018040.1858 (Melpa latest)
all-the-icons: 2018.0125.757 (Melpa latest)
all-the-icons-ivy: 20180225.630 (Melpa latest)

Code used:

(require 'all-the-icons-ivy)
(ivy-set-display-transformer 'ivy-switch-buffer 'all-the-icons-ivy-buffer-transformer)

Calling ivy-switch-buffer crashed emacs with a segmentation fault

I tried this

  (setq all-the-icons-ivy-file-commands
	'(counsel-find-file
	  counsel-file-jump
	  counsel-recentf
	  projectile-find-file
	  projectile-find-dir))

but it didn't work.

Hi,

there are some (minor) problems with all-the-icons-ivy on my machine.

Some entries are not iconified, and it is seems that this breaks the formatting, as you can see in the following screenshot.

Maybe this could be solved by having a generic icon for everything which has no specific icon.

Moreover, it also seems that the height of each entry is inconsistent. This is especially clear when you look at the highlighted region, which varies in height depending on the icon. For instance, in the previous screenshot, the white space is not balanced in the selected entry.

(I am aware that these are very fine details, and maybe they bother only me.)

Thanks,
sbozzolo

First of all, I would like to thank you for your work for the community.

Recently I tested your package and I found that when I use it, then I lose all the other information that ivy-rich can provide me. Indeed, on the left side of the image, we can see that the buffer language and other information have disappeared in favour of the icon.

If it can help, this is how I configure ivy-rich and all-the-icons-ivy packages:

(use-package ivy-rich
  :after ivy
  :custom
  (ivy-virtual-abbreviate 'full
                          ivy-rich-switch-buffer-align-virtual-buffer t
                          ivy-rich-path-style 'abbrev)
  :config (ivy-rich-mode 1))

(use-package all-the-icons-ivy
  :after (all-the-icons ivy)
  :custom (all-the-icons-ivy-buffer-commands '(ivy-switch-buffer-other-window))
  :config
  (add-to-list 'all-the-icons-ivy-file-commands 'counsel-dired-jump)
  (add-to-list 'all-the-icons-ivy-file-commands 'counsel-find-library)
  (all-the-icons-ivy-setup))

Do you have any idea how to fix this issue?

When I enable all-the-icons-ivy suddenly TRAMP operations take 3-4x longer, as it seems emacs repeatedly accesses the remote system. I can comment out all-the-icons-ivy and find-file and friends works almost instantly.

It would be great to be able to configure the spacer between icons and text by a variable. The default could still be a tab "\t" but with my current emacs theme, a simple space " " looks much better. At the moment I have to replace 2 functions to do so, which is not ideal :-)

As titled, from my experience in order for all-the-icons-ivy to work as expected, the setup needs to be done in an after-init hook. I suspect this is to prevent being overridden by other configs such as ivy-posframe.

Consider chainging the documentation for configuration to:

(use-package all-the-icons-ivy
  :hook (after-init . all-the-icons-ivy-setup))

Hello,

I think the ivy function returning icon for files can be updated according to the recent function all-the-icons-icon-for-dir, see here.

I suggest to go from

(defun all-the-icons-ivy-icon-for-file (s)
  "Return icon for filename S.
Return the octicon for directory if S is a directory.
Otherwise fallback to calling `all-the-icons-icon-for-file'."
  (cond
   ((string-match-p "\\/$" s)
    (all-the-icons-octicon "file-directory" :face 'all-the-icons-ivy-dir-face))
   (t (all-the-icons-icon-for-file s))))

to

(defun all-the-icons-ivy-icon-for-file (s)
  "Return icon for filename S.
Return the octicon for directory if S is a directory.
Otherwise fallback to calling `all-the-icons-icon-for-file'."
  (cond
   ((file-directory-p s)
    (all-the-icons-icon-for-dir s :face 'all-the-icons-ivy-dir-face))
   (t (all-the-icons-icon-for-file s))))

This is what is currently implemented in all-the-icons-dired, see here. It gives nice icons for special directories.

Thanks

Thx for this great package, I can easily choose files by counsel-find-file or so.

But when I use counsel-git-grep or counsel-rg, icons don't appear in minibuffer.
Is it known limitation?