apress / design-patterns-in-modern-cpp

Source code for 'Design Patterns in Modern C++' by Dmitri Nesteruk

Apress Source Code

This repository accompanies Design Patterns in Modern C++ by Dmitri Nesteruk (Apress, 2018).

Download the files as a zip using the green button, or clone the repository to your machine using Git.

Releases

Release v1.0 corresponds to the code in the published book, without corrections or updates.

Contributions

See the file Contributing.md for more information on how you can contribute to this repository.

design-patterns-in-modern-cpp's Issues

missing file?

in facade pattern,where is window.h?

bridge.cpp

I don't think the main() from bridge.cpp goes with bridge.cpp

unique_ptr lifetime bug in Builder.cpp

In Builder.cpp

  auto builder2 = HtmlElement::build("ul")
    ->add_child_2("li", "hello")->add_child_2("li", "world");
  cout << builder2 << endl;

builder2 doesn't store unique_ptr returned by HtmlElement::build, but stores HtmlBuilder* returned by add_child2.
unique_ptr is destroyed before call to cout and builder2 contains pointer to freed memory (address sanitizer error - heap use after free).

Solution: Increase unique_ptr lifetime by storing in local variable.

  auto builder = HtmlElement::build("ul");
  auto builder2 = builder->add_child_2("li", "hello")->add_child_2("li", "world");
  cout << builder2->str() << endl;

composite - neurons

I have a problem with compilation under gcc:

invalid use of incomplete type struct 'Neuron'.

In template struct SomeNeurons the compiler points from and to as problematic.