Coder Social home page Coder Social logo

Comments (4)

helje5 avatar helje5 commented on May 20, 2024

Your "end" counter is flawed, you need to put your counter in the schedule block:

Not this:

         case .end(_):
+            queue.sync {
+                if concurrentRequests > maxConcurrentRequests {
+                    maxConcurrentRequests = concurrentRequests
+                    print(maxConcurrentRequests)
+                }
+                concurrentRequests -= 1
+            }
+            
             _ = ctx.eventLoop.scheduleTask(in: delay) { () -> Void in

but this:

         case .end(_):
             _ = ctx.eventLoop.scheduleTask(in: delay) { () -> Void in
+              queue.sync {
+                  if concurrentRequests > maxConcurrentRequests {
+                      maxConcurrentRequests = concurrentRequests
+                      print(maxConcurrentRequests)
+                  }
+                  concurrentRequests -= 1
+              }
+            

(you count before the artificial "delay")

from swift-nio.

GeorgeLyon avatar GeorgeLyon commented on May 20, 2024

Whoops, I actually did catch this but posted an incorrect gist (I have updated it). This just adds 1. to the max (before it was 5, after it becomes 6) which is consistent with my theory that a single request seems to be blocking the next request from coming in.

from swift-nio.

helje5 avatar helje5 commented on May 20, 2024

How do you "spam the server"?

from swift-nio.

GeorgeLyon avatar GeorgeLyon commented on May 20, 2024

Ah thank you! You guessed correctly. My test environment was going between HTTP2 (for reference) and HTTP1 (for swift-nio, since it doesn't support 2 yet). Maximum number of HTTP1 connections (for my client) was 6. Increasing the maximum worked correctly.

from swift-nio.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.