Comments (7)
cc @yim-lee can you help us here. The performance tests seem to broken.
from swift-nio.
CC @tomerd
from swift-nio.
I just noticed that my manual tests occasionally failed. I reproduced it by running it in tight loop and eventually tracked it down to an apparent race in TCPThroughtputBenchmark
:
self.context.writeAndFlush
is called here[1], before context
is set here[2].
This may be the reason we don't get perf test results. Not the fact that perf testing infra is broken exactly.
[1]
[2]
from swift-nio.
CC @FranzBusch for flakey test (we should track that separately)
@gmilos good catch! However whatever happens in the performance tests should not make the harness post wrong and outdated data. Also, it's posting is so quickly that I doubt it ran anything at all
from swift-nio.
Agreed re the harness being immune to failures in the test binary.
For reference, I filed the issue about the specific test here: #2649
//cc @FranzBusch
from swift-nio.
It posts bogus results because the build doesn't get far enough to the cleanup stage to delete previous test result files, and the job is configured to post contents from the report file. I manually wiped the workspace this time. Updating the job to wipe workspace before build didn't help because it fails very early on (some Git operation), which I will look into now.
from swift-nio.
@tomerd fixed the issue (thanks!) and perf job is green again: #2652
from swift-nio.
Related Issues (20)
- Allocation counter tests don't work on macOS HOT 1
- Add `NIOBSDSocket.Option` for `SO_BROADCAST`
- Add way to differentiate between websocket upgrade failing and not attempting an upgrade HOT 1
- Thread running at User-interactive quality-of-service class waiting on a lower QoS thread running at Default quality-of-service class. HOT 2
- Add Channel.cancelOnClose(_:)
- Not working on iPadOS 17.4.1 HOT 1
- Remove swift-docc-plugin dependency
- Crash in NIOFileSystem HOT 2
- CBR„93//\/
- QUIC support in Swift HOT 1
- NIOFileSystem: Provide API to set last-modified timestamp (ie: "touch") HOT 2
- Remove all `#if swift(...)`s, all the ones I've seen in SwiftNIO are wrong. Needs to be `#if compiler` HOT 1
- 'LockStorage<Void>' has no member 'mutex' on Win11 HOT 1
- ByteBufferAllocator.allocate(capacity: Int) implementation does not correspond to the definition. HOT 7
- CMake build causes runtime crash from Atomics HOT 3
- Windows Support HOT 1
- ByteBuffer: Investigate optimal allocation sizes (probably just under a power of two) HOT 1
- MessageToByteHandler never shrinks its buffer (it should!)
- We should offer the same `[get/set]MultipleIntegers` as we offer for `[read/write]MultipleIntegers` methods on ByteBuffer HOT 7
- Forceful unwrapping of bytes in NIOCore HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from swift-nio.