Allocation counter tests don't work on macOS about swift-nio

[gmilos]

Ah, the problem is that the main test package, created by ./run-nio-alloc-counter-tests.sh is mis-structured. It contains the main test package which depends on AtomicCounter and HookedFunctions:

        .package(url: "HookedFunctions/", branch: "main"),
        .package(url: "AtomicCounter/", branch: "main"),

With AtomicCounter being a static .library. HookedFunctions also depends on AtomicCounter, but it is a .dynamic library. Which means that the counters collected by HookedFunctions are separate than the counters inspected by the main test binary afterwards.

The following change appears to fix the issue[1]. However, I've only tested in on macOS. We'd need to check Linux is also working fine.

[1]

diff --git a/IntegrationTests/allocation-counter-tests-framework/template/AtomicCounter/Package.swift b/IntegrationTests/allocation-counter-tests-framework/template/AtomicCounter/Package.swift
index 3e2edbf4..c1872d9e 100644
--- a/IntegrationTests/allocation-counter-tests-framework/template/AtomicCounter/Package.swift
+++ b/IntegrationTests/allocation-counter-tests-framework/template/AtomicCounter/Package.swift
@@ -19,7 +19,7 @@ import PackageDescription
 let package = Package(
     name: "AtomicCounter",
     products: [
-        .library(name: "AtomicCounter", targets: ["AtomicCounter"]),
+        .library(name: "AtomicCounter", type: .dynamic, targets: ["AtomicCounter"]),
     ],
     dependencies: [ ],
     targets: [