animmouse / setup-rclone Goto Github PK

Since macOS VMs use a few IP addresses, this action sometimes fail on macOS returning null in version variable, failing the download as the IP address got rate limited. actions/runner-images#602

API rate limit exceeded for IP. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)

[ERROR] CUID#7 - Download aborted. URI=https://github.com/rclone/rclone/releases/download/null/rclone-null-osx-amd64.zip
Exception: [AbstractCommand.cc:351] errorCode=3 URI=https://github.com/rclone/rclone/releases/download/null/rclone-null-osx-amd64.zip
-> [HttpSkipResponseCommand.cc:219] errorCode=3 Resource not found

One of our workflow run failed with the following error:

[ERROR] CUID#7 - Download aborted. URI=https://github.com/rclone/rclone/releases/download/null/rclone-null-osx-amd64.zip
Exception: [AbstractCommand.cc:351] errorCode=3 URI=https://github.com/rclone/rclone/releases/download/null/rclone-null-osx-amd64.zip
-> [HttpSkipResponseCommand.cc:219] errorCode=3 Resource not found

It seems to be that the error came from here, where for some reason the latest version was determined as null:

Maybe some additional check/retry logic could be implemented in case the version is not properly returned, to make the run more resilient.

This step also didn't fail (which it should have), even though it failed to install the tool. Additional check could be implemented for that too.

Run AnimMouse/setup-rclone@v1
  with:
    rclone_config: ***
Run $GITHUB_ACTION_PATH/scripts/download/Linux.sh
/__w/_actions/AnimMouse/setup-rclone/v1/scripts/download/Linux.sh: 3: jq: not found
Error: Process completed with exit code 127.

• Job:

runs-on: ubuntu-latest
container: python:3.10

• Step:

- name: Setup Rclone
   uses: AnimMouse/setup-rclone@v1
   with:
     rclone_config: ${{ secrets.RCLONE_CONFIG }}

Hey,

We've noticed your scripts are using aria2c and 7z to download and extract the rclone zip.
This creates a dependency requirements for self-hosted runners that can be avoided.
An additional benefit of removing these dependencies is that your code will run on any windows or linux machine (or at least the majority of them)

Windows

Download

You can do something similar to this:

$ProgressPreference = 'SilentlyContinue'  # hide progress barr
Invoke-WebRequest -Uri "https://....." -OutFile "C:\path\to\aria2c"
$ProgressPreference = 'Continue'  # return progress bar

Unzip

Something like this should work in powershell:

Expand-Archive C:\a.zip -DestinationPath C:\a

Linux

Download

The majority of linux distributions have curl or wget pre-installed.
This is also available in ubuntu and probably is already available in the github cloud runners

Unzip

The majority of linux distributions have unzip installed.
This is also available in ubuntu and probably is already available in the github cloud runners

The warning began to appear while running AnimMouse/setup-rclone@v1 action:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache/restore@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/

Thank you in advance